Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[javascript] Fix JavaScript build error in TravisCI #8374

Merged
merged 1 commit into from
Jun 3, 2020
Merged

[javascript] Fix JavaScript build error in TravisCI #8374

merged 1 commit into from
Jun 3, 2020

Conversation

seanpoulter
Copy link
Contributor

@seanpoulter seanpoulter commented Jun 1, 2020

Motivation and Context

The JavaScript build in TravisCI fails. The tests are not run. The error presents like this:

Error: Cannot find module '../../../../bazel-genfiles/javascript/node/selenium-webdriver/lib/atoms/find-elements.js'. Please verify that the package.json has a valid "main" entry
    at Function.module.constructor._resolveFilename (javascript/node/selenium-webdriver/tests_require_patch.js:482:17)
    at requireAtom (javascript/node/selenium-webdriver/lib/http.js:56:14)

Here is a recent example - https://travis-ci.com/github/SeleniumHQ/selenium/jobs/342002768.

Description

Test a hypothesis that find-Elements.js may be related to the missing module. This is the only spot in the repo where the E is capitalized.

This fixes the build error. The tests run and fail (as expected).

From https://travis-ci.com/github/SeleniumHQ/selenium/jobs/342002768:

image

CC: @harsha509

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation. No
  • I have updated the documentation accordingly. Not applicable
  • I have added tests to cover my changes. Not applicable
  • All new and existing tests passed. Maybe 🤞 (It is better than before).

@seanpoulter seanpoulter changed the title WIP: [javascript] Attempt to fix the JavaScript build in TravisCI [javascript] Fix JavaScript build error in TravisCI Jun 1, 2020
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @seanpoulter ,

Good one Thank you for fixing it

Regards,
Harsha

This is the only case where `find-elements.js` had a capital `E`.
@AutomatedTester AutomatedTester merged commit ab16292 into SeleniumHQ:master Jun 3, 2020
titusfortner pushed a commit to titusfortner/selenium that referenced this pull request Aug 13, 2020
This is the only case where `find-elements.js` had a capital `E`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants