[ruby] Fix Chrome::Options.process_browser_options

[masakazutakewaka]

Description

It errors when an Options instace with profile is passed to Driver.new in 'capabilities' key:

# cd /path/to/rb
$ bundle exec rails c
profile   = Selenium::WebDriver::Chrome::Profile.new
options = Selenium::WebDriver::Chrome::Options.new(profile: profile)
driver    = Selenium::WebDriver.for :chrome, capabilities: [options]

Traceback (most recent call last):
        1: from (irb):6
NoMethodError (undefined method `split' for :directory:Symbol)

Motivation and Context

passing an Array of options to Driver.new in :capabilities key is still a valid option when initializing a driver, so I suppose fixing this is important.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[masakazutakewaka]

confirmed this test case fails with master.

$ bundle exec rspec spec/unit/selenium/webdriver/chrome/driver_spec.rb:211
...

Failures:

  1) Selenium::WebDriver::Chrome::Driver with :capabilities when value is an Array with Options instance with profile
     Failure/Error: expect { Driver.new(capabilities: [options]) }.not_to raise_exception

       expected no Exception, got #<NoMethodError: undefined method `split' for :directory:Symbol> with backtrace:
         # ./lib/selenium/webdriver/chrome/profile.rb:60:in `[]'
         # ./lib/selenium/webdriver/chrome/options.rb:188:in `process_browser_options'
         # ./lib/selenium/webdriver/common/options.rb:81:in `as_json'
         # ./lib/selenium/webdriver/common/driver.rb:344:in `block in generate_capabilities'
         # ./lib/selenium/webdriver/common/driver.rb:332:in `map'
         # ./lib/selenium/webdriver/common/driver.rb:332:in `generate_capabilities'
         # ./lib/selenium/webdriver/common/driver.rb:320:in `create_bridge'
         # ./lib/selenium/webdriver/common/driver.rb:76:in `initialize'
         # ./spec/unit/selenium/webdriver/chrome/driver_spec.rb:216:in `new'
         # ./spec/unit/selenium/webdriver/chrome/driver_spec.rb:216:in `block (5 levels) in <module:Chrome>'
         # ./spec/unit/selenium/webdriver/chrome/driver_spec.rb:216:in `block (4 levels) in <module:Chrome>'
     # ./spec/unit/selenium/webdriver/chrome/driver_spec.rb:216:in `block (4 levels) in <module:Chrome>'

[p0deje]

Thanks you for the contribution!