Code refactor #8426
Merged
Code refactor #8426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merging as the failures don't look related. Chrome seems incredibly volatile in the run |
titusfortner
pushed a commit
to titusfortner/selenium
that referenced
this pull request
Aug 13, 2020
* Add getDistributor based on implementaion required * Resolve deps for new getDistributor method * Update deps * Change variable class name * Add Remote Distributor as default class * Add getClass method * Remove unused imports * Update getClass method * Use getClass for EventBus implementation * Create RemoteDistributor inline for RouterServer Co-authored-by: David Burns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following improvements:
getClassto config which returns the class based on theimplementationoption.create(Config config)method to distributor.Motivation and Context
Types of changes
Checklist