-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Hugo syntax fixed, for driver.quit() #2003
Incorrect Hugo syntax fixed, for driver.quit() #2003
Conversation
In Quitting session section, on drivers page, due to incorrect hugo syntax the driver.quit() was not being displayed for Java, Dotnet, JS and Kotlin. Fixed this issue, made the changes in all the supported language files, local verification done after the fixes. Fixes SeleniumHQ#2002
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Catch 🚀
Thank you @harshitBhardwaj97 !
Thanks for the kind words @harsha509. |
In Quitting session section, on drivers page, due to incorrect hugo syntax the driver.quit() was not being displayed for Java, Dotnet, JS and Kotlin. Fixed this issue, made the changes in all the supported language files, local verification done after the fixes. Fixes #2002 Co-authored-by: Sri Harsha <[email protected]> 584cc1c
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
In Quitting session section, on drivers page, due to incorrect hugo syntax the driver.quit() was not being displayed for Java, Dotnet, JS and Kotlin. Fixed this issue, made the changes in all the supported language files, local verification done after the fixes. Fixes #2002. Video attached showing the fixes -
seleniumIssue.2002.mp4
Motivation and Context
This change was required, because it shows how can we use driver.quit() in various language bindings.
Types of changes
Checklist
PR Type
Bug fix, Documentation
Description
driver.quit()
command.examples/dotnet/SeleniumDocs/GettingStarted/FirstScript.cs
.Changes walkthrough 📝
_index.en.md
Correct Hugo syntax and update CSharp code reference
website_and_docs/content/documentation/webdriver/drivers/_index.en.md
_index.ja.md
Correct Hugo syntax and update CSharp code reference
website_and_docs/content/documentation/webdriver/drivers/_index.ja.md
_index.pt-br.md
Correct Hugo syntax and update CSharp code reference
website_and_docs/content/documentation/webdriver/drivers/_index.pt-br.md
_index.zh-cn.md
Correct Hugo syntax and update CSharp code reference
website_and_docs/content/documentation/webdriver/drivers/_index.zh-cn.md