-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples for drivers http_client in java and python #2041
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Failure Feedback 🧐(Checks updated until commit 707454d)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
b52ac53
to
ea3d5f0
Compare
Signed-off-by: Viet Nguyen Duc <[email protected]>
ea3d5f0
to
37d1818
Compare
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
a5d1955
to
707454d
Compare
* Add examples for http_client java and python * Updated for other languages * Fix flaky test in examples python (#2042) [deploy site] --------- Signed-off-by: Viet Nguyen Duc <[email protected]> 2ce6752
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
enhancement, tests
Description
requests
library.Changes walkthrough 📝
2 files
conftest.py
Add Selenium grid server fixture and resource path function
examples/python/tests/conftest.py
requests
andHTTPBasicAuth
imports._get_resource_path
function for file path resolution.grid_server
fixture to start and manage a Selenium server.BaseTest.java
Enhance BaseTest with advanced grid start method
examples/java/src/test/java/dev/selenium/BaseTest.java
startStandaloneGridAdvanced
method with SSL configuration.2 files
test_http_client.py
Add tests for remote WebDriver with client config
examples/python/tests/drivers/test_http_client.py
grid_server
fixture for test setup.HttpClientTest.java
Add HttpClient tests with SSL and authentication
examples/java/src/test/java/dev/selenium/drivers/HttpClientTest.java
4 files
tls.crt
Add TLS certificate for Java tests
examples/java/src/test/resources/tls.crt
tls.key
Add TLS private key for Java tests
examples/java/src/test/resources/tls.key
tls.crt
Add TLS certificate for Python tests
examples/python/tests/resources/tls.crt
tls.key
Add TLS private key for Python tests
examples/python/tests/resources/tls.key
1 files
requirements.txt
Update Python requirements with requests library
examples/python/requirements.txt
requests
library to requirements.1 files
http_client.en.md
Update Python code block in documentation
website_and_docs/content/documentation/webdriver/drivers/http_client.en.md