Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "pipelines": [] in config #335

Closed
JosephMarinier opened this issue Dec 8, 2022 · 0 comments · Fixed by #406
Closed

Handle "pipelines": [] in config #335

JosephMarinier opened this issue Dec 8, 2022 · 0 comments · Fixed by #406
Labels
bug Something isn't working
Milestone

Comments

@JosephMarinier
Copy link
Contributor

JosephMarinier commented Dec 8, 2022

When you configure "pipelines": [], the back end currently crashes with an IndexError: list index out of range in postprocessing_known().

I suspect users might try "pipelines": [] if they start with a config with a pipeline and then adapt it to a new dataset, for example, and remove the pipeline.

I see two options:

  1. We forbid "pipelines": [], but we handle it clearly in a config validator.
  2. We support "pipelines": [] just like if it was "pipelines": null.
@JosephMarinier JosephMarinier converted this from a draft issue Dec 8, 2022
@JosephMarinier JosephMarinier added the bug Something isn't working label Dec 8, 2022
@JosephMarinier JosephMarinier changed the title Handle "pipeline": [] in config Handle "pipelines": [] in config Dec 14, 2022
@gabegma gabegma moved this from 🆕 New to 🏗 In progress in Azimuth Jan 27, 2023
@gabegma gabegma moved this from 🏗 In progress to 👀 In review in Azimuth Jan 27, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Azimuth Jan 31, 2023
@gabegma gabegma added this to the v2.6.0 milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants