-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings for model averaging in the frontend #620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's awesome - thanks Fred for the PR and sorry for the delay in reviewing! @JosephMarinier could you take a look at the front end files when you have a chance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! That looks good to me!
Co-authored-by: Gabrielle Gauthier Melancon <[email protected]>
Cool! Can you trigger the CI and then y'all can merge whenever? |
Oh yeah... 🤔 I don't know what is going on with the CI. I'll try to investigate. |
This super elaborate suggestion from Stack Overflow (close + reopen) didn't work. Does anyone have an idea what is going on? |
@JosephMarinier and @gabegma, My guess would be that in your project settings you have enabled branch protection rules. For a collaborator to be able to push in main, both the backend and frontend CI need to succeed. Also, my understanding is that workflows on PR from outside contributors might not run automatically, and might be approved first. After being approved, the workflows will get triggered. However, both jobs only run on Assuming that this is reason of the issue, I think that adding the For the latter, you can have a look at Controlling changes from forks to workflows in public repositories. |
Co-authored-by: Joseph Marinier <[email protected]>
Head branch was pushed to by a user without write access
Resolve #Nothing
Description:
This PR allows the user to see the performance after bayesian model averaging. This generally improves the performance by ~1-2% and the ECE by a couple percentage as well.
In my company, we use BMA in production to get good ECE, this is why I need this toggle.
Lot of code, but mostly poutine here are the relevant bits:
model_averaging_available
to Dataset InfoChecklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-files
at the end.our users.
README
files and our wiki for any big design decisions, if relevant.