Allow .NET clients to cancel streams started with StreamFrom #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcb
commented
Sep 15, 2021
| @@ -8,7 +8,7 @@ open System.Threading | |||
| open System.Threading.Tasks | |||
|
|
|||
| type internal IHubConnection<'ClientApi,'ClientStreamFromApi,'ClientStreamToApi,'ServerApi,'ServerStreamApi> (hub: HubConnection) = | |||
| member _.ConnectionId = | |||
There was a problem hiding this comment.
Ugh, so much trailing whitespace removed on account of an extension. Hopefully that's OK (can ignore whitespace in diff settings to remove this noise)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
fake buildor.\build.cmd) on local branch was successfulPull request type
Please check the type of change your PR introduces:
What is the current behavior?
No ability to pass a
CancellationTokentoHubConnection<...>.StreamFromin the .NET client.What is the new behavior?
StreamFromnow accepts an optionalCancellationToken, just like other streaming methods.Does this introduce a breaking change?
Other information
Fixes #32