[Theme] Fix serving local assets that contain non-printable characters

[frandiox]

WHY are these changes introduced?

Closes #4479

WHAT is this pull request doing?

• The main issue was caused by non-printable characters, which have a different length in disk vs in memory (string format). By transforming them to Buffer before reading the length we get the real disk value, which is required for content-length header.

• Unrelated fixes: consider replacing CDN links in JS files with single quotes, etc.

How to test your changes?

Added a unit test to show it.

cc @Shopify/advanced-edits

[github-actions]

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

• Themes: @shopify/advanced-edits
• UI extensions: @shopify/ui-extensions-cli
  • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
• Hydrogen: @shopify/hydrogen
• Other: @shopify/app-inner-loop

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	73.03% (+0.01% 🔼)	8391/11490
🟡	Branches	69.54% (+0.02% 🔼)	4092/5884
🟡	Functions	71.81%	2181/3037
🟡	Lines	73.38% (+0.01% 🔼)	7940/10821

Test suite run success

1890 tests passing in 858 suites.

Report generated by 🧪jest coverage report action from 0a6475b

[charlespwd]

This LGTM! Curious why we have to figure out the content-length for our server. That seems like a low level detail that the server lib usually provides for us.

(I'm really out of the loop here, so if what we're doing is is pretty low level, I understand!)

Those URL regex do be gnarly af though. Took me a couple of sips of coffee to get why they were modified :P

[frandiox]

Thanks for the review! Yeah we are using a lowish level server called h3 and it requires us passing the content-length, otherwise the browser doesn't get the files properly.

Those URL regex do be gnarly af though. Took me a couple of sips of coffee to get why they were modified :P

Yep, just simplifying them a bit 😅 -- I think we'll probably forget about RegExps and just ask AI to change them for us 😂

[frandiox]

/snapit

[github-actions]

🫰✨ Thanks @frandiox! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.