Allow BalanceStrategy to provide custom assignment data #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The StickyBalanceStrategy currently provides state information with member assignments. This is achieved through a custom name check in the `syncGroupRequest` of the consumer group. This works well for this case, but falls apart when trying to create additional stateful balance strategies. This update will make it possible to create new stateful balance strategies
ghost
added
the
d1egoaz
reviewed
Jan 30, 2020
There was a problem hiding this comment.
Thanks @aldelucca1
I've added one question.
Would be possible somehow to add a test for this in balance_strategy_test.go?
consumer_group.go
Outdated
| return nil, err | ||
| } | ||
| assignment.UserData = userDataBytes | ||
| userDataBytes, err := strategy.AssignmentData(plan, memberID, generationID) |
There was a problem hiding this comment.
wondering why you'd need to send the plan and member to AssignmentData to get the topics:
topics, ok := plan[memberID]
if !ok {
return nil, nil
}if that was already obtained in the range above?
Line 335 for memberID, topics := range plan
There was a problem hiding this comment.
My thinking here was in the case the state being shipped needed to understand data about the larger plan, but I am happy limiting the scope to just the given member and its assigned topics.
There was a problem hiding this comment.
thanks for the fast response!
I'll 👀 later today
bai
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The StickyBalanceStrategy currently provides state information with member assignments. This is achieved through a custom name check in the
syncGroupRequestof the consumer group. This works well for this case, but falls apart when trying to create additional stateful balance strategies. This update will make it possible to create new stateful balance strategies