Fix two decoding bugs found by go-fuzz #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(https://github.com/dvyukov/go-fuzz) - handle negative message-set sizes in FetchResponses - handle IPv6 and/or malformed broker addresses
| b.addr = net.JoinHostPort(host, fmt.Sprint(port)) | ||
| if _, _, err := net.SplitHostPort(b.addr); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
I assume this was because of a hostname with a colon in it?
There was a problem hiding this comment.
and hostnames with [ in them and \0 and all sorts of other interesting garbage that go-fuzz generated
|
Nice work 👏 🚢 |
eapache
added a commit
that referenced
this pull request
Aug 26, 2015
Fix two decoding bugs found by go-fuzz
eapache
added a commit
that referenced
this pull request
Aug 27, 2015
The fix in #523 did not cover all cases, as found by subsequent go-fuzz runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(https://github.com/dvyukov/go-fuzz)
@Shopify/kafka