Fix HashPartitioner's negative result #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find, thanks! |
eapache
added a commit
that referenced
this pull request
Jul 18, 2016
Also remove unnecessary variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: I have found that for some Key, the Partition function of HashPartitioner return negative value. After I investigate the issue, I have found that if the fnv's Sum32 function returns 2147483648, which is -2147483648 in int32 and the negative of this will still be -2147483648 causing the negative result returned.
Reproduce: this issue can be reproduced by using "1468509572224" as message's key.
Change:
Please feel free to suggest the better way to fix this issue.