-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github action to automatically update list of all lanuage files and contributors #68
Comments
They are not lost. As described in the Readme, each version gets its own branch. As a user of these language files, you can think of these as separate directories, each containing the language files for a particular plugin version.
Each version branch should only contain runnable and fully translated language files for that version. If there are changes required from one version to the next, it would be confusing for users of those language files to find language files that are not actually compatible with their desired plugin version. I agree that the repository structure of separating the translations for different plugin versions into different branches (rather than for example different folders) makes the discoverability of previous language files a bit more difficulty. For plugin users, it is quite simple to select the version they are interested in and then find all the language files available for that version. But for translators, it is inconvenient having to search through all past branches to find the last translation for their language. Unfortunately, Github doesn't seems to offer a way to also search other branches for files. However, the repository was explicitly changed to this structure (it was different in the beginning) to simplify the updating of language files from one version to the next: It is quite easy to view the history and differences of files between different versions / branches directly on Github (e.g. 54bf095#diff-5362bae55e2c64449d2ae0d0b95129da5eb035b538ea8ee62fd568a0a55aef89). But there is no easy way to view the differences of files located at different paths / folders. Regarding the contributors lists: There are links to the contributor files for each version. Inheriting/Copying over the list of contributors of previous versions into the contributors file for the current branch would make maintenance worse: Whenever there are changes to the contributors in a previous version (each branch/version can evolve separately), one would also need to update the contributor lists in the all of the subsequent versions/branches to mention them there as well. So instead of doing that, or having outdated contributor lists, I chose to only list the contributors for the current version and instead link to the always up-to-date contributor files for all the previous versions. If you have any other ideas that fulfill the following criteria, let me know:
|
@blablubbabc thank you very much for such a detailed answer. I do not have any particular advice how to reorganize this github repository, maybe it is not necessary at all. Here it is:
The table displays the most recent plugin version for which a translation into particular language exists, and compares it with the current language-en-default.yml file, thus indicating the amount of efforts necessary to update the translation to the current plugin version. (If you like, I can add the check for missing placeholders/color codes.) We can see that UK and UA are two completely different translations into Ukrainian language, and the same thing with Chinese translations: zh_CN , zh-CN . So it's not only myself so stupid, other translators also fail to find existing translations. You can use this script as you like, to make it more easy to find translations for your contributors. :) |
Maybe an option could be to have a build action on Github automatically update an index file on the current main branch whenever there are some changes in any branch. |
I love this idea and it would really help, is there anything we can do? |
When a new brunch for a new version ( even a minor/patch one) is created, previously existing translations are lost.
For example, there are just 3 translation (as of 2024-08-05) in v2.22.2, but there were 7 of them in v2.20.0 including ru and uk.
I translated all the lines into Russian before I realized that this translation had already existed.
A guy who wants a Russian translation for 2.22.3 will probably translate it all over again.
Note, that Contributors list for the previous versions is also empty, despite translations existed.
I guess language files should be somehow inherited from the previous version, even incomplete/obsolete ones.
Obviously, if an original line is changed, corresponding translated line should be cleared up.
The text was updated successfully, but these errors were encountered: