Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render dict[str, bool] block input as collapsible multi-select #8538

Closed
Tracked by #8358
Pwuts opened this issue Nov 4, 2024 — with Linear · 2 comments
Closed
Tracked by #8358

Render dict[str, bool] block input as collapsible multi-select #8538

Pwuts opened this issue Nov 4, 2024 — with Linear · 2 comments

Comments

Copy link
Member

Pwuts commented Nov 4, 2024

PR #8358 adds at least one block with an event filter input:

image.png

This is ugly and impractical. To fix this, it should be rendered as a multi-select dropdown (example):

image.png

To generalize this to how we render inputs in general:
an object input on a block should be rendered as a multi-select dropdown if all of its sub-inputs are booleans and it has 3 or more sub-inputs.

@Pwuts
Copy link
Member Author

Pwuts commented Nov 5, 2024

dd446a7

@Pwuts Pwuts closed this as completed Nov 5, 2024
Copy link
Member Author

Pwuts commented Nov 5, 2024

Technically this is implemented now, but the NodeMultiSelectInput doesn't yet behave like it should. Clicking on an item doesn't add it to the selection. Outside of the node, e.g. on the agent submission page, this does work. I'm guessing there is some custom click event handling going on that makes it not work, but idk.

Selecting an item using my arrow keys + enter works, so the way the component is integrated doesn't seem to be the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant