Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] Scaffold component is missing on Safari #953

Open
datdoan opened this issue Mar 16, 2022 · 4 comments
Open

[Vue] Scaffold component is missing on Safari #953

datdoan opened this issue Mar 16, 2022 · 4 comments
Labels
backlog Issue/PR/discussion is reviewed and added to backlog for the further work keep

Comments

@datdoan
Copy link
Contributor

datdoan commented Mar 16, 2022

Description

New scaffolded component is missing on Safari browser.

Expected behavior

The scaffolded component should mounted on page

Steps To Reproduce

  1. Start with the Vue sample app
  2. Scaffold a component using jss scaffold MyComponent
  3. Add the component in data/routes/en.yml
  4. jss start local and open in Safari browser
  5. See error message on page "JSS component is missing Vue implementation. See the developer console for more information."

Possible Fix

Your Environment

  • Sitecore Version: -
  • JSS Version: 19.0.2
  • Mode: Disconnected
  • Browser Name and version: 14.1.2 (16611.3.10.1.6)
  • Operating System and version (desktop or mobile): MacOS 11.6.4 (20G417)
  • Link to your project (if available): -

Screenshots

image
image

@markgibbons25
Copy link

You need to run jss deploy after you scaffold a new component

@datdoan
Copy link
Contributor Author

datdoan commented Mar 17, 2022

You need to run jss deploy after you scaffold a new component

Thanks for the solution, that works.

Didn't have to jss deploy for it to work/hot reload on Chrome, Brave and Firefox. Could this be a bug or just a limitation of Safari?

@markgibbons25
Copy link

Yes it does seem like a bug, I didn't realise you were working in disconnected mode, that error would be normal in connected mode if you hadn't done a deploy, but in disconnected mode it's unexpected.

@datdoan
Copy link
Contributor Author

datdoan commented Mar 17, 2022

I've recreated the same step with React template, no issue with Safari.

@illiakovalenko illiakovalenko added the backlog Issue/PR/discussion is reviewed and added to backlog for the further work label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issue/PR/discussion is reviewed and added to backlog for the further work keep
Projects
None yet
Development

No branches or pull requests

4 participants