Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[templates/angular] Apply webpack resolve alias for angular, only in our monorepo #1990

Merged
merged 2 commits into from
Dec 3, 2024
Merged

[templates/angular] Apply webpack resolve alias for angular, only in our monorepo #1990

merged 2 commits into from
Dec 3, 2024

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Dec 3, 2024

Description / Motivation

PR to apply the webpack resolve alias setting in angular template only when scaffolding sample in monorepo.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@yavorsk yavorsk requested a review from a team December 3, 2024 15:45
@yavorsk yavorsk changed the title apply webpack resolve alias for angular only in our monorepo [templates/angular] Apply webpack resolve alias for angular, only in our monorepo Dec 3, 2024
@yavorsk yavorsk merged commit 128550d into dev Dec 3, 2024
1 check passed
@yavorsk yavorsk deleted the feature/JSS-4653 branch December 3, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art-alexeyenko art-alexeyenko art-alexeyenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yavorsk @art-alexeyenko