Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this work in 2019.3? I get pink texture #6

Open
keybol opened this issue May 22, 2020 · 3 comments
Open

Does this work in 2019.3? I get pink texture #6

keybol opened this issue May 22, 2020 · 3 comments

Comments

@keybol
Copy link

keybol commented May 22, 2020

Does this work in 2019.3?

@keybol
Copy link
Author

keybol commented May 22, 2020

Also, what are those 8 Ignore Shaders By Name you included in ShaderStripperVariantCollection

@keybol
Copy link
Author

keybol commented May 22, 2020

What does this warning mean?

Sigtrap.Editors.ShaderStripper.ShaderStripperEditor must be instantiated using the ScriptableObject.CreateInstance method instead of new ShaderStripperEditor.
UnityEditor.EditorWindow:.ctor()
Sigtrap.Editors.ShaderStripper.ShaderStripperEditor:.ctor() (at Assets/Editor/ShaderStripperEditor.cs:42)
UnityEditor.EditorApplication:Internal_CallGlobalEventHandler()

@SixWays
Copy link
Owner

SixWays commented May 23, 2020

It does work in 2019.3 - however ShaderStripperVariantCollection is unfortunately very hard to use correctly. Unity doesn't seem to actually include all necessary variants in the collection files it generates, so this stripper will strip far more than you actually intend. I recommend only using it for debug purposes, e.g. if you're testing a specific set of shaders and want to keep build time to an absolute minimum.

I'm not sure what you mean by the 8 ignore shaders by name. If "8" is a typo, and you're asking how Ignore Shaders By Name works, it just doesn't strip any shaders matching those patterns even if they're not in the collection(s).

That warning does pop up sometimes and I'm not sure why, but it doesn't seem to cause any problems for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants