Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dmsg Hypervisor PR #79

Closed
wants to merge 8 commits into from
Closed

Dmsg Hypervisor PR #79

wants to merge 8 commits into from

Conversation

jdknives
Copy link
Member

@jdknives jdknives commented Dec 2, 2019

Fixes #78

Changes:

  • copied this PR

How to test this PR:

  • not yet tested

@jdknives jdknives marked this pull request as ready for review January 21, 2020 12:57
nkryuchkov
nkryuchkov suggested changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@nkryuchkov nkryuchkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! We also need to fix the makeConfig call in the TestNewNode test, because it requires an argument now.

cmd/hypervisor/commands/gen-config.go Outdated Show resolved Hide resolved
cmd/hypervisor/commands/root.go Outdated Show resolved Hide resolved
pkg/hypervisor/config.go Outdated Show resolved Hide resolved
pkg/hypervisor/config.go Show resolved Hide resolved
pkg/hypervisor/config.go Outdated Show resolved Hide resolved
pkg/hypervisor/hypervisor.go Outdated Show resolved Hide resolved
pkg/visor/rpc_client.go Outdated Show resolved Hide resolved
pkg/visor/rpc_client.go Outdated Show resolved Hide resolved
pkg/visor/visor.go Outdated Show resolved Hide resolved
pkg/visor/visor.go Outdated Show resolved Hide resolved
@Kifen Kifen mentioned this pull request Jan 23, 2020
Merged
@jdknives
Copy link
Member Author

Superseded by #124

@jdknives jdknives closed this Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kifen Kifen Kifen left review comments

@nkryuchkov nkryuchkov nkryuchkov requested changes

@evanlinjin evanlinjin Awaiting requested review from evanlinjin

@Darkren Darkren Awaiting requested review from Darkren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdknives @nkryuchkov @Kifen