[NO JIRA]: Upgrade eslint-config-skyscanner to latest to support incomming TS support #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zgeor
reviewed
Feb 17, 2022
zgeor
reviewed
Feb 17, 2022
zgeor
reviewed
Feb 17, 2022
zgeor
reviewed
Feb 17, 2022
zgeor
reviewed
Feb 17, 2022
packages/bpk-component-infinite-scroll/src/withInfiniteScroll-test.flow.js
Show resolved
Hide resolved
zgeor
reviewed
Feb 17, 2022
olliecurtis
force-pushed
the
no-jira-upgrade-linting-for-ts
branch
3 times, most recently
from
13d599b to
6107ac5
Compare
olliecurtis
force-pushed
the
no-jira-upgrade-linting-for-ts
branch
from
6107ac5 to
d578e42
Compare
olliecurtis
commented
Feb 17, 2022
| @@ -2,6 +2,9 @@ | |||
| .*/node_modules/jsonlint/.* | |||
| .*/node_modules/config-chain/test/broken.json | |||
|
|
|||
| # This is expected as this malformed file is for a test in the library. | |||
| .*/node_modules/resolve/test/resolver/malformed_package_json/package.json | |||
There was a problem hiding this comment.
Had to add this ignore here to the flowconfig as flow was throuwing an error on an external dependency which is expected as the file is part of a test.
zgeor
approved these changes
Feb 17, 2022
|
Visual regression tests passed 😎. Bear in mind that they only run in Chromium on static components – they aren't perfect. |
|
Visit https://backpack.github.io/storybook-prs/2376 to see this build running in a browser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR spilts out from #2368 and completes the linting separately before we merge the TS framework as this linter upgrade is needed for the TS framework support.
There is a lot of file changes with the vast majority of the changes being
prettieradding()around parameters for functions.