Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail on run rector #37

Open
snapshotpl opened this issue Oct 14, 2022 · 3 comments
Open

Fail on run rector #37

snapshotpl opened this issue Oct 14, 2022 · 3 comments

Comments

@snapshotpl
Copy link

When I run rector with this extension rector fails. Running phpstan works fine. Ping @samsonasik

[ERROR] Could not process "module/EcommerceApi/tests/integration/ElasticsearchProductsCollectionQueryTest.php" file, due to: 
         "System error: "Unable to resolve service "ApplicationConfig" to a factory; are you certain you provided it during
         configuration?"                                                                                                
                                                                                                                        
         Stack trace:                                                                                                   
         #0 vendor/laminas/laminas-servicemanager/src/ServiceManager.php(607):                                          
         Laminas\ServiceManager\ServiceManager->getFactory('ApplicationConf...')                                        
         #1 vendor/laminas/laminas-servicemanager/src/ServiceManager.php(230):                                          
         Laminas\ServiceManager\ServiceManager->doCreate('ApplicationConf...')                                          
         #2 vendor/laminas/laminas-mvc/src/Service/ModuleManagerFactory.php(32):                                        
         Laminas\ServiceManager\ServiceManager->get('ApplicationConf...')                                               
         #3 vendor/laminas/laminas-servicemanager/src/ServiceManager.php(608):                                          
         Laminas\Mvc\Service\ModuleManagerFactory->__invoke(Object(Laminas\ServiceManager\ServiceManager), 'ModuleManager',
         NULL)                                                                                                          
         #4 vendor/laminas/laminas-servicemanager/src/ServiceManager.php(230):                                          
         Laminas\ServiceManager\ServiceManager->doCreate('ModuleManager')                                               
         #5 vendor/slam/phpstan-laminas-framework/src/UnmappedAliasServiceLocatorProxy.php(40):                         
         Laminas\ServiceManager\ServiceManager->get('ModuleManager')                                                    
         #6 vendor/slam/phpstan-laminas-framework/src/Type/Laminas/ServiceManagerGetDynamicReturnTypeExtension.php(92): 
         LaminasPhpStan\UnmappedAliasServiceLocatorProxy->get('ModuleManager')                                          
         #7 phar://vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(3561):       
         LaminasPhpStan\Type\Laminas\ServiceManagerGetDynamicReturnTypeExtension->getTypeFromMethodCall(Object(PHPStan\Reflectio
         n\ResolvedMethodReflection), Object(PhpParser\Node\Expr\MethodCall), Object(PHPStan\Analyser\MutatingScope))   
         #8 phar://vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(1411):       
         PHPStan\Analyser\MutatingScope->methodCallReturnType(Object(PHPStan\Type\ObjectType), 'get',                   
         Object(PhpParser\Node\Expr\MethodCall))                                                                        
         #9 phar://vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(1417):       
         PHPStan\Analyser\MutatingScope->PHPStan\Analyser\{closure}()                                                   
         #10 phar://vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(572):       
         PHPStan\Analyser\MutatingScope->resolveType(Object(PhpParser\Node\Expr\MethodCall))                            
         #11 phar://vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(789):       
         PHPStan\Analyser\MutatingScope->getType(Object(PhpParser\Node\Expr\MethodCall))                                
         #12 phar://vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(572):       
         PHPStan\Analyser\MutatingScope->resolveType(Object(PhpParser\Node\Expr\Assign))                                
         #13 phar://vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(1393):  
         PHPStan\Analyser\MutatingScope->getType(Object(PhpParser\Node\Expr\Assign))                                    
         #14 phar://vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(530):   
         PHPStan\Analyser\NodeScopeResolver->findEarlyTerminatingExpr(Object(PhpParser\Node\Expr\Assign),               
         Object(PHPStan\Analyser\MutatingScope))                                                                        
         #15 phar://vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(336):   
         PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\Expression),                    
         Object(PHPStan\Analyser\MutatingScope), Object(Closure))                                                       
         #16 phar://vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(494):   
         PHPStan\Analyser\NodeScopeResolver->processStmtNodes(Object(PhpParser\Node\Stmt\ClassMethod), Array,           
         Object(PHPStan\Analyser\MutatingScope), Object(Closure))                                                       
         #17 phar://vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(336):   
         PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\ClassMethod),                   
         Object(PHPStan\Analyser\MutatingScope), Object(PHPStan\Node\ClassStatementsGatherer))                          
         #18 phar://vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(572):   
         PHPStan\Analyser\NodeScopeResolver->processStmtNodes(Object(PhpParser\Node\Stmt\Class_), Array,                
         Object(PHPStan\Analyser\MutatingScope), Object(PHPStan\Node\ClassStatementsGatherer))                          
         #19 phar://vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(336):   
         PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\Class_),                        
         Object(PHPStan\Analyser\MutatingScope), Object(Closure))                                                       
         #20 phar://vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(544):   
         PHPStan\Analyser\NodeScopeResolver->processStmtNodes(Object(PhpParser\Node\Stmt\Namespace_), Array,            
         Object(PHPStan\Analyser\MutatingScope), Object(Closure))                                                       
         #21 phar://vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(306):   
         PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\Namespace_),                    
         Object(PHPStan\Analyser\MutatingScope), Object(Closure))                                                       
         #22 vendor/rector/rector/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php(298):            
         PHPStan\Analyser\NodeScopeResolver->processNodes(Array, Object(PHPStan\Analyser\MutatingScope), Object(Closure))
         #23 vendor/rector/rector/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php(212):            
         Rector\NodeTypeResolver\PHPStan\Scope\PHPStanNodeScopeResolver->processNodesWithDependentFiles('vendor...', Array,
         Object(PHPStan\Analyser\MutatingScope), Object(Closure))                                                       
         #24 vendor/rector/rector/packages/NodeTypeResolver/NodeScopeAndMetadataDecorator.php(48):                      
         Rector\NodeTypeResolver\PHPStan\Scope\PHPStanNodeScopeResolver->processNodes(Array, 'vendor...')               
         #25 vendor/rector/rector/src/PhpParser/AstResolver.php(317):                                                   
         Rector\NodeTypeResolver\NodeScopeAndMetadataDecorator->decorateNodesFromFile(Object(Rector\Core\ValueObject\Application
         \File), Array)                                                                                                 
         #26 vendor/rector/rector/src/PhpParser/AstResolver.php(137):                                                   
         Rector\Core\PhpParser\AstResolver->parseFileNameToDecoratedNodes('vendor...')                                  
         #27 vendor/rector/rector/rules/Php80/Rector/ClassMethod/AddParamBasedOnParentClassMethodRector.php(108):       
         Rector\Core\PhpParser\AstResolver->resolveClassMethodFromMethodReflection(Object(PHPStan\Reflection\Php\PhpMethodReflec
         tion))                                                                                                         
         #28 vendor/rector/rector/src/Rector/AbstractRector.php(213):                                                   
         Rector\Php80\Rector\ClassMethod\AddParamBasedOnParentClassMethodRector->refactor(Object(PhpParser\Node\Stmt\ClassMethod
         ))                                                                                                             
         #29 vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(176):                         
         Rector\Core\Rector\AbstractRector->enterNode(Object(PhpParser\Node\Stmt\ClassMethod))                          
         #30 vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(105):                         
         PhpParser\NodeTraverser->traverseArray(Array)                                                                  
         #31 vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(196):                         
         PhpParser\NodeTraverser->traverseNode(Object(PhpParser\Node\Stmt\Class_))                                      
         #32 vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(105):                         
         PhpParser\NodeTraverser->traverseArray(Array)                                                                  
         #33 vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(196):                         
         PhpParser\NodeTraverser->traverseNode(Object(PhpParser\Node\Stmt\Namespace_))                                  
         #34 vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(85):                          
         PhpParser\NodeTraverser->traverseArray(Array)                                                                  
         #35 vendor/rector/rector/src/PhpParser/NodeTraverser/RectorNodeTraverser.php(42):                              
         PhpParser\NodeTraverser->traverse(Array)                                                                       
         #36 vendor/rector/rector/src/Application/FileProcessor.php(60):                                                
         Rector\Core\PhpParser\NodeTraverser\RectorNodeTraverser->traverse(Array)                                       
         #37 vendor/rector/rector/src/Application/FileProcessor/PhpFileProcessor.php(133):                              
         Rector\Core\Application\FileProcessor->refactor(Object(Rector\Core\ValueObject\Application\File),              
         Object(Rector\Core\ValueObject\Configuration))                                                                 
         #38 vendor/rector/rector/src/Application/FileProcessor/PhpFileProcessor.php(100):                              
         Rector\Core\Application\FileProcessor\PhpFileProcessor->refactorNodesWithRectors(Object(Rector\Core\ValueObject\Applica
         tion\File), Object(Rector\Core\ValueObject\Configuration))                                                     
         #39 vendor/rector/rector/packages/Parallel/WorkerRunner.php(98):                                               
         Rector\Core\Application\FileProcessor\PhpFileProcessor->process(Object(Rector\Core\ValueObject\Application\File),
         Object(Rector\Core\ValueObject\Configuration))                                                                 
         #40 vendor/rector/rector/vendor/evenement/evenement/src/Evenement/EventEmitterTrait.php(97):                   
         Rector\Parallel\WorkerRunner->Rector\Parallel\{closure}(Array)                                                 
         #41 vendor/rector/rector/vendor/clue/ndjson-react/src/Decoder.php(110):                                        
         RectorPrefix202209\Evenement\EventEmitter->emit('data', Array)                                                 
         #42 vendor/rector/rector/vendor/evenement/evenement/src/Evenement/EventEmitterTrait.php(97):                   
         RectorPrefix202209\Clue\React\NDJson\Decoder->handleData(Array)                                                
         #43 vendor/rector/rector/vendor/react/stream/src/Util.php(62): RectorPrefix202209\Evenement\EventEmitter->emit('data',
         Array)                                                                                                         
         #44 vendor/rector/rector/vendor/evenement/evenement/src/Evenement/EventEmitterTrait.php(97):                   
         RectorPrefix202209\React\Stream\Util::RectorPrefix202209\React\Stream\{closure}('{"action":"main...')          
         #45 vendor/rector/rector/vendor/react/stream/src/DuplexResourceStream.php(154):                                
         RectorPrefix202209\Evenement\EventEmitter->emit('data', Array)                                                 
         #46 vendor/rector/rector/vendor/react/event-loop/src/StreamSelectLoop.php(201):                                
         RectorPrefix202209\React\Stream\DuplexResourceStream->handleData(Resource id #3093)                            
         #47 vendor/rector/rector/vendor/react/event-loop/src/StreamSelectLoop.php(173):                                
         RectorPrefix202209\React\EventLoop\StreamSelectLoop->waitForStreamActivity(NULL)                               
         #48 vendor/rector/rector/src/Console/Command/WorkerCommand.php(63):                                            
         RectorPrefix202209\React\EventLoop\StreamSelectLoop->run()                                                     
         #49 vendor/rector/rector/vendor/symfony/console/Command/Command.php(307):                                      
         Rector\Core\Console\Command\WorkerCommand->execute(Object(RectorPrefix202209\Symfony\Component\Console\Input\ArgvInput)
         , Object(RectorPrefix202209\Symfony\Component\Console\Output\ConsoleOutput))                                   
         #50 vendor/rector/rector/vendor/symfony/console/Application.php(894):                                          
         RectorPrefix202209\Symfony\Component\Console\Command\Command->run(Object(RectorPrefix202209\Symfony\Component\Console\I
         nput\ArgvInput), Object(RectorPrefix202209\Symfony\Component\Console\Output\ConsoleOutput))                    
         #51 vendor/rector/rector/vendor/symfony/console/Application.php(310):                                          
         RectorPrefix202209\Symfony\Component\Console\Application->doRunCommand(Object(Rector\Core\Console\Command\WorkerCommand
         ), Object(RectorPrefix202209\Symfony\Component\Console\Input\ArgvInput),                                       
         Object(RectorPrefix202209\Symfony\Component\Console\Output\ConsoleOutput))                                     
         #52 vendor/rector/rector/src/Console/ConsoleApplication.php(49):                                               
         RectorPrefix202209\Symfony\Component\Console\Application->doRun(Object(RectorPrefix202209\Symfony\Component\Console\Inp
         ut\ArgvInput), Object(RectorPrefix202209\Symfony\Component\Console\Output\ConsoleOutput))                      
         #53 vendor/rector/rector/vendor/symfony/console/Application.php(208):                                          
         Rector\Core\Console\ConsoleApplication->doRun(Object(RectorPrefix202209\Symfony\Component\Console\Input\ArgvInput),
         Object(RectorPrefix202209\Symfony\Component\Console\Output\ConsoleOutput))                                     
         #54 vendor/rector/rector/bin/rector.php(128): RectorPrefix202209\Symfony\Component\Console\Application->run()  
         #55 vendor/rector/rector/bin/rector(5): require_once('vendor...')                                              
         #56 vendor/bin/rector(120): include('vendor...')                                                               
         #57 {main}". On line: 552
@samsonasik
Copy link

Could you share step by step to reproduce? Possibly require include bootstrap to resolve class/service

@snapshotpl
Copy link
Author

When I disable AddParamBasedOnParentClassMethodRector other php 8.0 rules works

@samsonasik
Copy link

Could you provide reproduced repository with github action running? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snapshotpl @samsonasik