You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I worked on #27 I missed that the ServiceManagerGetDynamicReturnTypeExtension is actually restricted to ServiceLocatorInterface through getClass(), i.e. it does not support \Interop\Container\ContainerInterface or \Psr\Container\ContainerInterface. Hence, I wrongly updated the README.md documentation (first item under "This extension provides following features:"), too.
This feature request is to add support for letting this extension determine the return type of get() method calls on instances of either \Interop\Container\ContainerInterface or \Psr\Container\ContainerInterface, assuming that they are actually returning a ServiceManager instance.
Hopefully all that needs to be done here is to extract the implementation of ServiceManagerGetDynamicReturnTypeExtension to an abstract base class and then providing three subclasses (one per container type). Didn't check whether the class is covered by tests yet.
Please fix the README.md statement until this issue is resolved.
The text was updated successfully, but these errors were encountered:
When I worked on #27 I missed that the ServiceManagerGetDynamicReturnTypeExtension is actually restricted to ServiceLocatorInterface through getClass(), i.e. it does not support \Interop\Container\ContainerInterface or \Psr\Container\ContainerInterface. Hence, I wrongly updated the README.md documentation (first item under "This extension provides following features:"), too.
This feature request is to add support for letting this extension determine the return type of get() method calls on instances of either \Interop\Container\ContainerInterface or \Psr\Container\ContainerInterface, assuming that they are actually returning a ServiceManager instance.
Hopefully all that needs to be done here is to extract the implementation of ServiceManagerGetDynamicReturnTypeExtension to an abstract base class and then providing three subclasses (one per container type). Didn't check whether the class is covered by tests yet.
Please fix the README.md statement until this issue is resolved.
The text was updated successfully, but these errors were encountered: