Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No diskfree data for second client #1

Closed
Sly1024 opened this issue Feb 28, 2016 · 1 comment
Closed

No diskfree data for second client #1

Sly1024 opened this issue Feb 28, 2016 · 1 comment

Comments

@Sly1024
Copy link
Owner

Sly1024 commented Feb 28, 2016

For a performance improvement the diskfree module only sends updates to a wsPubSub channel if the output changed compared to the previous state. The stream is started when the first client connects and subscribes, so it gets the first update, but when the second client connects it does not get any update on that channel if the output is not changing.

Adding SOW (state of the world) support for wsPubSub will solve this, so I'm not fixing this separately.
@Sly1024
Copy link
Owner Author

Sly1024 commented Mar 17, 2016

Started fix in: 6888b8c
Completed in: 3218d41

@Sly1024 Sly1024 closed this as completed Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sly1024