🐛 Use {} as fallback for history.yaml. #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, YAML.load_file returns false for an empty file, which messed the whole thing up.
kinow
approved these changes
Jun 20, 2019
|
Hmmm, unfortunately two build failures in Travis @YtvwlD . Otherwise ready to merge I think |
|
These failures also happen with the current master: https://travis-ci.org/YtvwlD/smashing |
|
I was afraid of that. Let me find some time to investigate it later and then we can rebase this one and merge. |
|
Thinking twice, it actually passes in one of the Ruby versions. So let's merge and will sort the build in Travis later in a separate issue 👍 |
|
Thank you. :) |
|
Thank you for your contribution @YtvwlD ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, YAML.load_file returns false for an empty file,
which messed the whole thing up.