Upgrading font awesome to 5.11 #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
approved these changes
Nov 1, 2019
There was a problem hiding this comment.
Approved in principle. I don't know much about updating FA 4.x to 5.x. The number of requests seem to have increased. I also don't know if we have a way to minify/bundle resources together to reduce the size of requests.
But you seem to have picked the right files, changed only what was necessary, and the final Dashboard works in my environment (confirmed in the CSS retrieved that it shows the right FA version).
Let's see if someone else will review it too.
Thanks @brujoand !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huge disclaimer, I have no idea what I'm doing here. I make shells pretty, not html. What I've done:
I created a new project and it looked okay to me.