Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error string when widget not rendered #27

Merged
merged 1 commit into from
Dec 9, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/dashing/app.rb
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ def protected!
file = File.join(settings.root, "widgets", params[:widget], "#{params[:widget]}.#{suffix}")
return engines.first.new(file).render if File.exist? file
end
"Drats! Unable to find a widget file named: #{params[:widget]} to render."
end

def send_event(id, body, target=nil)
Expand Down
8 changes: 8 additions & 0 deletions test/app_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,14 @@ def test_get_widget
end
end

def test_get_nonexistent_widget
with_generated_project do
get '/views/nowidget.html'
assert_equal 200, last_response.status
assert_equal last_response.body, 'Drats! Unable to find a widget file named: nowidget to render.'
end
end

def with_generated_project
source_path = File.expand_path('../../templates', __FILE__)

Expand Down