Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Height and width of the notes container #22

Conversation

iaayushmaan
Copy link

The height and width of the container are now fixed to content.

Fixes #21

Screenshot 2023-12-31 014317

  • Bug fix (non-breaking change which fixes an issue)

  • Self-reviewed the code.

@ShaikArshidBanu
Copy link
Contributor

This issue was assigned to me.

@iaayushmaan
Copy link
Author

When I solved this issue, there hadn't been any assignments made to it at that time.

@ShaikArshidBanu
Copy link
Contributor

When I solved this issue, there hadn't been any assignments made to it at that time.

@iaayushmaan According to the code of conduct you should get the issue assigned to you before you solve it.only those who get assigned the issue can solve it.

@nisha-laur
Copy link
Contributor

@iaayushmaan @ShaikArshidBanu . See It's okay but from next time please do take care of it . For now , I will reveiw @iaayushmaan PR and if it is fine then @iaayushmaan Please first get the issue assigned first before raising a PR and If there is some modifications to be done . Then @ShaikArshidBanu you can start working on this issue .

@nisha-laur
Copy link
Contributor

@iaayushmaan The issue still exist and also not that while raising a PR you attach the screen shots of before and after .

@nisha-laur nisha-laur closed this Jan 1, 2024
@iaayushmaan
Copy link
Author

iaayushmaan commented Jan 1, 2024

@nisha-laur In my browser, It worked absolutely fine. Pl check the file changes and recommend what went wrong.
Regards

@nisha-laur nisha-laur reopened this Jan 1, 2024
@nisha-laur
Copy link
Contributor

@iaayushmaan Add screen shots of Before and After

@nisha-laur
Copy link
Contributor

This is What I can see
image
and you have just added 'align-items-start ' class in the div . But does not seem to resolve the issue .Let me clearify the issue . This issue is supposed to correct the width and height of the notes div like a grid :-
image
I hope , you got now . If not feel free to ask .

@nisha-laur nisha-laur closed this Jan 1, 2024
@iaayushmaan
Copy link
Author

iaayushmaan commented Jan 1, 2024

@nisha-laur I misunderstood the issue, but Now, I got it. Thanks!
@ShaikArshidBanu Address the issue with full description like @nisha-laur did. Hope you find the difference.
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Notes container is not fit to the content.
3 participants