feat: add possibility to surcharge next router listener #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m-maillot @Viczei @carolineBda Vous en pensez quoi ? De mon côté, je pensais propager d'autres valeurs supplémentaires comme D'ailleurs ça peut poser soucis ici car on ne va pas le setter |
carolineBda
reviewed
Jan 11, 2023
maxgfr
changed the title
revolunet
approved these changes
Jan 12, 2023
Codecov ReportBase: 85.00% // Head: 86.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 85.00% 86.15% +1.15%
==========================================
Files 1 1
Lines 60 65 +5
Branches 16 20 +4
==========================================
+ Hits 51 56 +5
Misses 1 1
Partials 8 8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
revolunet
approved these changes
Jan 12, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2023
# [1.5.0](v1.4.0...v1.5.0) (2023-01-13) ### Features * add possibility to surcharge next router listener ([#88](#88)) ([f1bf4a2](f1bf4a2))
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch allows users to surcharge the method from Next.js router
onChangeStartandonChangeCompletethat is used in the library