Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#105) ๊ฒŒ์‹œ๊ธ€ ์ƒ์„ธ ์ •๋ณด API #124

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

lyutvs
Copy link
Collaborator

@lyutvs lyutvs commented Jun 22, 2022

close #105

@lyutvs lyutvs added the ๊ธฐ๋Šฅ ์ถ”๊ฐ€ ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์š”์ฒญ์„ ๋‚˜ํƒ€๋ƒ…๋‹ˆ๋‹ค. label Jun 22, 2022
@lyutvs lyutvs self-assigned this Jun 22, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!ย  ย  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AllArgsConstructor
public class ImageUrlListResponse {

private final List<ImageUrlResponse> imageLists;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฑด String ๋ฐฐ์—ด๋กœ ํ•˜๋ฉด ๋  ๊ฒƒ ๊ฐ™์€๋ฐ ์™œ ํˆฌํ”Œ์ž„?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list ์•„๋‹ˆ์—ˆ์Œ?

Copy link
Member

@softpeanut softpeanut Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String ํƒ€์ž…์˜ List

private final CommentAttachmentFileRepository commentAttachmentFileRepository;

@Transactional(readOnly = true)
public FeedDetailsResponse execute(Integer feedId) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•ˆ๋˜๊ฒ ๋‹ค ์ด๊ฑฐ querydsl๋กœ ๋งน๊ธ€์ž
์ค€์„œ๋„ ๋„ˆ๋ฌด ์—ฌ๋Ÿฌ๋ฒˆ ์กฐํšŒํ•˜๋˜๋ฐ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๊ธฐ๋Šฅ ์ถ”๊ฐ€ ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์š”์ฒญ์„ ๋‚˜ํƒ€๋ƒ…๋‹ˆ๋‹ค.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๊ฒŒ์‹œ๊ธ€ ์ƒ์„ธ ์ •๋ณด API
3 participants