Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 :: (#120) 게시글 작성 API #123

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

🔀 :: (#120) 게시글 작성 API #123

wants to merge 6 commits into from

Conversation

lyutvs
Copy link
Collaborator

@lyutvs lyutvs commented Jun 22, 2022

close #120

@lyutvs lyutvs added the 기능 추가 새로운 기능 요청을 나타냅니다. label Jun 22, 2022
@lyutvs lyutvs self-assigned this Jun 22, 2022
softpeanut
softpeanut reviewed Jun 30, 2022
View reviewed changes
src/main/java/com/example/moizaspringserver/domain/feed/presenstation/FeedController.java Outdated

@ResponseStatus(HttpStatus.NO_CONTENT)
@DeleteMapping("/{feed-id}")
public void deleteFeed(@PathVariable("feed-id") Integer feedId) {
deleteFeedService.execute(feedId);
}

@ResponseStatus(HttpStatus.CREATED)
@PostMapping
public void createFeed(@Valid @RequestBody CreateFeedRequest request) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이것도 순서가..

...a/com/example/moizaspringserver/domain/feed/presenstation/dto/request/CreateFeedRequest.java Outdated
@NotBlank(message = "title은 Null, 공백, 띄어쓰기를 허용하지 않습니다.")
private String title;

@NotNull(message = "content은 Null, 공백, 띄어쓰기를 허용하지 않습니다.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얘도 는..

...a/com/example/moizaspringserver/domain/feed/presenstation/dto/request/CreateFeedRequest.java Outdated
@NotNull(message = "feed_type은 Null일 수 없습니다.")
private FeedType feedType;

@NotNull(message = "category은 Null일 수 없습니다.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 @notblank

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softpeanut softpeanut softpeanut left review comments

@glay415 glay415 glay415 approved these changes

@ericlee05 ericlee05 ericlee05 approved these changes

Assignees

@lyutvs lyutvs

Labels
기능 추가 새로운 기능 요청을 나타냅니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

게시글 작성 API
4 participants
@lyutvs @ericlee05 @softpeanut @glay415