Fix IE11 "SCRIPT16389: Unspecified error." when dragging element #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE11 throws error "SCRIPT16389: Unspecified error." when dragging element after
Sortable.create(...)was executed more than 1 time while in same page (without page reload).This issue happens also in Sortable earlier versions, and due to this error may stop Sortable functionality at all.
Using
el.parentNodefor simplest fix checking if element sort of exists in DOM (by checking if parent element exists). Universal fix would be to usedocument.body.contains(el), but I think it is too much here and would cause small performance impact, that's way fixing it is simple way.