Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Settings Page #383

Merged
merged 1 commit into from
Sep 22, 2015
Merged

Conversation

jakejarrett
Copy link
Member

Adds a settings page to Soundnode & Ability to disable desktop notifications from soundnode.

Also adds keyboard shortcut ( control/cmd + , )

screenshot from 2015-09-20 19-47-03

Closes #382

@Pitros
Copy link
Contributor

Pitros commented Sep 20, 2015

You could use ng-checked for settings view.

@jakejarrett
Copy link
Member Author

@Pitros i'm not too familiar with ng-checked. I'll give it a try and see what i can do.

@jakejarrett
Copy link
Member Author

@Pitros I switched it to ng-checked 👍 Thanks for the heads up (I misunderstood what ng-checked was for initially)

@Pitros
Copy link
Contributor

Pitros commented Sep 22, 2015

Now it looks simplier 👍 , ng-model on input probably should work as well but that's a quick note.

@jakejarrett jakejarrett force-pushed the settings-page branch 2 times, most recently from b432f90 to a735f6f Compare September 22, 2015 14:35
@weblancaster
Copy link
Member

Looks good @jakejarrett thanks for working on this.. pretty cool feature.

weblancaster added a commit that referenced this pull request Sep 22, 2015
@weblancaster weblancaster merged commit 88a2f34 into Soundnode:master Sep 22, 2015
@weblancaster
Copy link
Member

I'm just going to do some refactoring although everything works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants