Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Soundnode logo in case IMG src returns 404 #545

Merged
merged 1 commit into from
Feb 1, 2016

Conversation

vincelwt
Copy link
Contributor

It has happened to me with song "M83 - Wait (Kygo Remix) " for example.

It has happened to me with song "M83 - Wait (Kygo Remix) " for example.
@weblancaster
Copy link
Member

hey @vincelwt we have a "solution" in place where replace the null image to soundnode logo.. can you check if that is working because otherwise your work might overlap with what is in place.

thanks.

@vincelwt
Copy link
Contributor Author

I have the following :

soundnode

The console returns a 404 on this image.

So it's seems like the null solution isn't working for 404, at least for me.

@PatrickRoethlisberger
Copy link

@vincelwt Same happened to me when i start the program... After a reload, the picture was loaded..

@weblancaster
Copy link
Member

Thanks @vincelwt

weblancaster added a commit that referenced this pull request Feb 1, 2016
Show Soundnode logo in case IMG src returns 404
@weblancaster weblancaster merged commit dd8c4cb into Soundnode:master Feb 1, 2016
@vincelwt vincelwt deleted the patch-1 branch February 1, 2016 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants