Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required bindings to the like count container. closes #562 #568

Merged
merged 2 commits into from
Feb 19, 2016
Merged

Add required bindings to the like count container. closes #562 #568

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a78f28
Issue #562: Add required bindings to the like count container
vladjerca Jan 29, 2016
1bed78d
favoriteSongDirective: Count now updates after adding/removing like:
Feb 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/public/stylesheets/sass/_components/_track.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
.trackView {
& .likes_count {
&.liked {
& > i {
color: $scColor;
}
}
}
& .trackDetails {
display: flex;

Expand Down
4 changes: 3 additions & 1 deletion app/views/track/track.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
<span class="playback_count">
<i class="fa fa-play"></i> {{track.playback_count | number}}
</span>
<span class="likes_count">
<span class="likes_count" ng-click="changeLike()"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have ng-click="changeLike()" but isn't being used.

ng-class="{liked: track.user_favorite}"
favorite-song data-song-id="{{ track.id }}" favorite="track.user_favorite">
<i class="fa fa-heart"></i> {{track.favoritings_count | round}}
</span>
</div>
Expand Down