Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Reworked Top 50 Charts to be able to filter by genre #574

Merged
merged 5 commits into from
Feb 1, 2016
Merged

Conversation

fishr01
Copy link

@fishr01 fishr01 commented Jan 30, 2016

The updated will bring an option to listen to the top 50 for each genre - much like on the current soundcloud website.

@weblancaster weblancaster changed the title [FEATURE] - Reworked Top 50 Charts to be able to filter by genre [FEATURE] - Reworked Top 50 Charts to be able to filter by genre Jan 30, 2016
@cenderin
Copy link
Contributor

cenderin commented Feb 1, 2016

Nice!, can't wait for the next release with this in it. Good work!

@weblancaster
Copy link
Member

@fishr01 this is a great work.. would you fix the conflicts before I can merge please?

@fishr01
Copy link
Author

fishr01 commented Feb 1, 2016

@weblancaster Great! Glad you like it, actually my first time working on these technologies. Will fix it up quick and update.

@fishr01
Copy link
Author

fishr01 commented Feb 1, 2016

@weblancaster Okay that felt like alot more work that it should of been. Let me know if I need to correct any of this.

weblancaster added a commit that referenced this pull request Feb 1, 2016
[FEATURE] - Reworked Top 50 Charts to be able to filter by genre
@weblancaster weblancaster merged commit ec13e77 into Soundnode:master Feb 1, 2016
@weblancaster
Copy link
Member

Great job @fishr01 people are going to love this.. I'm just going to do some minor ui updates.

@fishr01
Copy link
Author

fishr01 commented Feb 1, 2016

@weblancaster Awesome! This is my first decent contribution to a public repo! Feelsgood!

@Pitros
Copy link
Contributor

Pitros commented Feb 1, 2016

@weblancaster are you going to work on those button list aswell? (If not I would like to try to replace them with more ux friendly option)

@weblancaster
Copy link
Member

Yes I did some improvements already checkout #595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants