Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logged in user text links to their profile page (fix #642) #733

Merged
merged 2 commits into from
Jul 1, 2016

Conversation

dgattey
Copy link
Contributor

@dgattey dgattey commented Apr 12, 2016

Click the username at top left to link to their profile page per #642. Doesn't show reposts, but ordinary profiles don't show reposts, so loading reposts should be a separate issue IMO. A few changes came together for this:

  1. Slight tweaking of css of logged in user to make it clearer
  2. $state.go to $rootscope.userId's profile from there
  3. On profile page, not showing follow button if user is the logged in user (since following/unfollowing yourself makes no sense)

@dgattey
Copy link
Contributor Author

dgattey commented Apr 21, 2016

Just commenting to see what you think @weblancaster. Anything else to do before a merge?

@weblancaster
Copy link
Member

hey @dgattey my apologies with my super delay in testing this PR.

I was going to merge but before I tested and turns out there is a minor issue.. the reason is that you need to add a null check on the profileCtrl where we call replace.

screen shot 2016-07-01 at 3 07 04 pm

I'm merging and then fix myself so we don't prolong.

@weblancaster weblancaster merged commit 6e447d5 into Soundnode:master Jul 1, 2016
weblancaster pushed a commit that referenced this pull request Jul 1, 2016
weblancaster added a commit that referenced this pull request Jul 1, 2016
@dgattey
Copy link
Contributor Author

dgattey commented Jul 1, 2016

Thanks

@dgattey dgattey deleted the fix-642 branch July 1, 2016 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants