Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: doesnt work on folia #97

Open
ewof opened this issue Nov 18, 2024 · 4 comments
Open

[BUG]: doesnt work on folia #97

ewof opened this issue Nov 18, 2024 · 4 comments
Labels
Bug A unintentional behavior that needs to be fixed Platform: Folia

Comments

@ewof
Copy link

ewof commented Nov 18, 2024

Describe what happend

from what i understand its bc the object task always executes on the server AFTER the last await() finishes
it should execute the task then in get it should await and by then the task finishes executing so value isnt null but it never does that until after it finishes awaiting so task.get in getBlockState in Locator class is always null this might be because all the code is running on the region thread so execute schedules the task then the latch awaits before the task even started running which means the task doesnt run until after the latch finishes awaiting

i had this convo with elecetroniccat in the paper discord might be useful to u might not idk https://discord.com/channels/289587909051416579/1090729705222721637/1308115336758956052

Reproduction steps

use on folia

Expected behavior

the tree falls down

Media

No response

Java Version

Java 21

Server Software

folia

Minecraft Version

1.21.1

Plugin Version

latest commit

Additional Information

No response

@ewof ewof added the Bug A unintentional behavior that needs to be fixed label Nov 18, 2024
@Lauriichan
Copy link
Member

I am pretty sure that the latch doesn't block the regional thread as the thread that is actually calling the getBlockState method is not a regional or "synchornous" thread (I know thats wrong wording here) or at least it shouldn't be

@Lauriichan
Copy link
Member

Can you please provide a list of the plugins you are using?

@ewof
Copy link
Author

ewof commented Nov 18, 2024

it happens on folia even when smoothtimber is the only plugin

@Lauriichan
Copy link
Member

Fixed folia not breaking trees in e530b52.
However I'll keep this open to keep track of the speed of tree breaking, trees break extremely slowly (delayed) on folia because of how the scheduling works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A unintentional behavior that needs to be fixed Platform: Folia
Projects
None yet
Development

No branches or pull requests

2 participants