Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Remote location for the chromium brotli file #18

Closed
Sparticuz opened this issue Nov 21, 2022 · 2 comments
Closed

[REQUEST] Remote location for the chromium brotli file #18

Sparticuz opened this issue Nov 21, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Sparticuz
Copy link
Owner

Sparticuz commented Nov 21, 2022

Implement the ability to have the chromium brotli file stored somewhere besides the package. This would enable us to get around 50mb limits that seem to plague vercel and other services that limit the deployable size.

test("Check the page title of example.com", async (t) => {
  const browser = await puppeteer.launch({
    args: chromium.args,
    defaultViewport: chromium.defaultViewport,
    executablePath: await chromium.executablePath("https://bucket.s3.amazonaws.com/chromium108.br"),
    headless: chromium.headless,
    ignoreHTTPSErrors: true,
  });
});

test("Check the page title of example.com", async (t) => {
  const browser = await puppeteer.launch({
    args: chromium.args,
    defaultViewport: chromium.defaultViewport,
    executablePath: await chromium.executablePath("/opt/chromium.br"),
    headless: chromium.headless,
    ignoreHTTPSErrors: true,
  });
});

Closes #24
Closes #8

@Sparticuz Sparticuz added enhancement New feature or request help wanted Extra attention is needed labels Nov 21, 2022
@Sparticuz Sparticuz changed the title [REQUEST] Remote location for the chromium brotli file [REQUEST] Alternate/Remote location for the chromium brotli file Dec 9, 2022
@Sparticuz
Copy link
Owner Author

This was only partially fixed in #26. I still would like to implement the remote brotli option.

@Sparticuz Sparticuz reopened this Dec 28, 2022
@Sparticuz Sparticuz changed the title [REQUEST] Alternate/Remote location for the chromium brotli file [REQUEST] Remote location for the chromium brotli file Dec 28, 2022
@Sparticuz
Copy link
Owner Author

v109.0.6 has been published with now lets you use a remote location for the brotli files (now a .tar pack). Super thanks to @aqaurius6666 for the code!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant