Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericWrite ACL not collected on OU #38

Open
sploutchy opened this issue Sep 6, 2022 · 2 comments
Open

GenericWrite ACL not collected on OU #38

sploutchy opened this issue Sep 6, 2022 · 2 comments

Comments

@sploutchy
Copy link

sploutchy commented Sep 6, 2022

The ACL Processor collects GenericAll, WriteDACL and WriteOwner ACLs on all object types.

For GenericWrite and WriteProperty, it collects the ACLs only for User, Group and Computer (and to some extent GPOs):

https://github.com/BloodHoundAD/SharpHoundCommon/blob/a2cc6c1bff4e3879c9329e89822d7e82e6806911/src/CommonLib/Processors/ACLProcessor.cs#L338-L392

I just stumbled upon a case where an Everyone has GenericWrite on an OU, this can be exploited as shown in the following articles:

I think this edge should also be collected on OUs. What do you think?

Thanks a lot for your great work!

@hubert3
Copy link

hubert3 commented Nov 29, 2022

Agree this should be collected on OUs as well if possible

@rvazarkar
Copy link
Contributor

I think historically, we've resisted adding this edge because the exploitation of this primitive is very complex and relies on several factors that are hard to enumerate. Maybe its time we took another look at it, but exploitation is still very complex, relying on ability to add DNS records or new computers for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants