-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(2095): Refactor UnclosedResourcesProcessor #557
refactor(2095): Refactor UnclosedResourcesProcessor #557
Conversation
Coverage on diff less than 100% as some conditions never evaluate to false (for example, we don't have any case where |
Just closing/opening to try to run CI again, Codecov is failing across all projects... |
Codecov uploads are just failing across every single project... I'm sick of Codecov failing now, time to look for an alternative. EDIT: I'm now ignoring Codecov upload failures in Sorald. I don't have time to replace it right now, we'll just have to do code coverage manually for the time being. |
@slarse, it looks good to me. Should I merge? |
@fermadeiral Yes, I've verified locally that coverage is acceptable, you can take my word for it :) |
I got stuck trying to fix #540 because this processor is a bit complex. This PR completely refactors the
UnclosedResourcesProcessor
to make it easier to reason about.