Chore(WIN-2123): Handle kwargs properly for Ruby 3 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aamirsahmad
force-pushed
the
aamir/WIN-2123-address-deprecation-warning-active-operation
branch
from
369e08a to
3661bfc
Compare
shahidkhaliq
reviewed
Nov 1, 2024
Comment on lines
+33
to
+34
| when :keyreq, :key | ||
| input name, type: :keyword, required: (type == :keyreq) |
There was a problem hiding this comment.
What is this change and why was it required?
There was a problem hiding this comment.
Previously the API was method(*args), now it supports both method(*args, **kwargs) so this is to ensure positional arg is required and kwargs aren't
| @@ -130,15 +130,19 @@ def inherited(subclass) | |||
| def initialize(*args) | |||
| arity = self.class.inputs.count(&:positional?) | |||
| arguments = args.shift(arity) | |||
| attributes = args.last.kind_of?(Hash) ? args.pop : {} | |||
| attributes = if args.last.is_a?(Hash) | |||
| args.pop.transform_keys(&:to_sym) | |||
There was a problem hiding this comment.
I think some test cases were failing and this fixed them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses the Ruby 2.7 deprecation warning: "Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call"
Testing