-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for general api token #54
Conversation
Hi @mjtice thanks for the contribution. This looks pretty good. I loaded this in my st2-docker test environment and ran some quick tests. All of the actions work beautifully with the new auth method however we also need to update the sensor code in your branch. Somewhere around here: Otherwise we get an exception when the sensor starts as it is unaware of the new
If you wouldn't mind fixing that up, I see no issues merging this. Thanks again! |
Sorry one other small detail you will want to update this in |
I added the api_token auth method into the sensors. They were also missing 'pat' and 'cookie' so I added them, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Sensor is now working in my test env. Thanks for adding the missing auth methods in the sensor as well, much appreciated.
No description provided.