Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a metrics about BE's tablets' max rowset count #36469

Closed
decster opened this issue Dec 5, 2023 · 0 comments · Fixed by #36539
Closed

Add a metrics about BE's tablets' max rowset count #36469

decster opened this issue Dec 5, 2023 · 0 comments · Fixed by #36539
Labels
type/enhancement Make an enhancement to StarRocks

Comments

@decster
Copy link
Contributor

decster commented Dec 5, 2023 •
edited
Loading

Enhancement

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.
@decster decster added the type/enhancement Make an enhancement to StarRocks label Dec 5, 2023
@decster decster changed the title Add a metrics about BE's tablets' max version number Add a metrics about BE's tablets' max rowset number Dec 5, 2023
@decster decster changed the title Add a metrics about BE's tablets' max rowset number Add a metrics about BE's tablets' max rowset count Dec 5, 2023
@decster decster mentioned this issue Dec 6, 2023
Merged
22 tasks
decster added a commit that referenced this issue Dec 7, 2023
@decster
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
555dfa6 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
mergify bot pushed a commit that referenced this issue Dec 7, 2023
@decster @mergify
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
4f8321d 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)

# Conflicts:
#	be/src/util/starrocks_metrics.cpp
mergify bot pushed a commit that referenced this issue Dec 7, 2023
@decster @mergify
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
da0457f 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)

# Conflicts:
#	be/src/util/starrocks_metrics.cpp
mergify bot pushed a commit that referenced this issue Dec 7, 2023
@decster @mergify
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
bc03f57 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)

# Conflicts:
#	be/src/util/starrocks_metrics.cpp
mergify bot pushed a commit that referenced this issue Dec 7, 2023
@decster @mergify
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
646a647 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)

# Conflicts:
#	be/src/util/starrocks_metrics.cpp
decster added a commit that referenced this issue Dec 7, 2023
@decster
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
076d192 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)
decster added a commit that referenced this issue Dec 7, 2023
@decster
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
d255f03 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)
decster added a commit that referenced this issue Dec 7, 2023
@decster
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
137adfb 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)
decster added a commit that referenced this issue Dec 7, 2023
@decster
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
7857214 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)
dingxin-tech pushed a commit to dingxin-tech/starrocks-odps that referenced this issue Dec 12, 2023
@decster @dingxin-tech
[Enhancement] Add max_tablet_rowset_num metrcis (StarRocks#36539)
7f660d2 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes StarRocks#36469

Signed-off-by: Binglin Chang <[email protected]>
Signed-off-by: 鼎昕 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Make an enhancement to StarRocks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Enhancement] Add max_tablet_rowset_num metrcis decster/starrocks
1 participant
@decster