[Refactor] add getCatalogDbName and getCatalogTableName in Table
#53072
+456
−488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirtysalt
requested review from
Seaven,
stephen-shelby,
HangyuanLiu,
DorianZheng and
Youngwb
HangyuanLiu
previously approved these changes
Nov 22, 2024
stephen-shelby
previously approved these changes
Nov 22, 2024
Signed-off-by: yanz <[email protected]>
Signed-off-by: yanz <[email protected]>
dirtysalt
dismissed stale reviews from stephen-shelby, HangyuanLiu, and LiShuMing
via
3ad06e8
dirtysalt
force-pushed
the
refactor-table-concept
branch
from
24403c2
to
3ad06e8
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 198 / 278 (71.22%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
|
@mergify backport branch-3.4 |
✅ Backports have been created
|
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 23, 2024
…` (backport #53072) (#53150) Signed-off-by: yanz <[email protected]> Co-authored-by: RyanZ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
There are so many overlapped concepts and interfaces on tables
HiveMetaStoreTablewhich basically have all interfaces inTablegetTableNameandgetNameto get table name.Tableshould havegetDbNameas a basic method but actually does not have. And it leads many subclasses to havegetDbNamewhich is really bad.But there are some tricks right here: when you use resource mapping:
namein table means the table name in local tablecatalogTableNamemeans the table name in catalogSo here is the solution:
getNameto get name in local tablegetCatalogTableName/getCatalogDBNameto get db/table in catalog.What I'm doing:
This PR is to:
getCatalogDbName()in Table, which alsmost all subclasses need.getCatalogTableName()HiveMetaStoreTableconcept from FE.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: