Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Optimize the performance of bitmap_xor using native roaring_bitmap function #34069

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[Enhancement] Optimize the performance of bitmap_xor using native roaring_bitmap function #34069

merged 1 commit into from
Oct 31, 2023

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Oct 31, 2023 •
edited
Loading

Optimize the performance of bitmap_xor using native roaring_bitmap function

mysql> select count(bitmap_xor(c2, c3)) from t1;                                                                                            
+---------------------------+                                                                                                               
| count(bitmap_xor(c2, c3)) |                                                                                                               
+---------------------------+                                                                                                               
|                     38496 |                                                                                                               
+---------------------------+

Before optimization:

ExprComputeTime: 2s731ms

After optimization

ExprComputeTime: 2s154ms

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@silverbullet233 silverbullet233 enabled auto-merge (squash) October 31, 2023 12:08
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@silverbullet233 silverbullet233 merged commit a57f31c into StarRocks:main Oct 31, 2023
41 checks passed
@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/types/bitmap_value.cpp 1 1 100.00% []

Moonm3n pushed a commit to Moonm3n/starrocks that referenced this pull request Oct 31, 2023
@trueeyu @Moonm3n
[Enhancement] Optimize the performance of bitmap_xor using native roa…
ee76f62 
…ring_bitmap function (StarRocks#34069)

Signed-off-by: trueeyu <[email protected]>
Signed-off-by: Moonm3n <[email protected]>
trueeyu added a commit to trueeyu/starrocks that referenced this pull request Nov 14, 2023
@trueeyu
[Enhancement] Optimize the performance of bitmap_xor using native roa…
42789c2 
…ring_bitmap function (StarRocks#34069)

Signed-off-by: trueeyu <[email protected]>
@trueeyu trueeyu mentioned this pull request Nov 14, 2023
Merged
22 tasks
@trueeyu
Copy link
Contributor Author

trueeyu commented Nov 14, 2023

https://github.com/Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@trueeyu @mergify
[Enhancement] Optimize the performance of bitmap_xor using native roa…
8ec3076 
…ring_bitmap function (#34069)

Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit a57f31c)
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
@trueeyu
Copy link
Contributor Author

trueeyu commented Nov 14, 2023

https://github.com/Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@trueeyu @mergify
[Enhancement] Optimize the performance of bitmap_xor using native roa…
3505938 
…ring_bitmap function (#34069)

Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit a57f31c)
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
@trueeyu
Copy link
Contributor Author

trueeyu commented Nov 14, 2023

https://github.com/Mergifyio backport branch-3.0

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@trueeyu @mergify
[Enhancement] Optimize the performance of bitmap_xor using native roa…
29407ce 
…ring_bitmap function (#34069)

Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit a57f31c)
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
@trueeyu
Copy link
Contributor Author

trueeyu commented Nov 14, 2023

https://github.com/Mergifyio backport branch-2.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@trueeyu @mergify
[Enhancement] Optimize the performance of bitmap_xor using native roa…
7ed45fb 
…ring_bitmap function (#34069)

Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit a57f31c)
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@trueeyu @wanpengfei-git
[Enhancement] Optimize the performance of bitmap_xor using native roa…
765216d 
…ring_bitmap function (#34069)

Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit a57f31c)
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@trueeyu @wanpengfei-git
[Enhancement] Optimize the performance of bitmap_xor using native roa…
41148de 
…ring_bitmap function (#34069)

Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit a57f31c)
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@trueeyu @wanpengfei-git
[Enhancement] Optimize the performance of bitmap_xor using native roa…
a0e7c8e 
…ring_bitmap function (#34069)

Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit a57f31c)
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@trueeyu @wanpengfei-git
[Enhancement] Optimize the performance of bitmap_xor using native roa…
d46f24f 
…ring_bitmap function (#34069)

Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit a57f31c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangkaisen kangkaisen kangkaisen approved these changes

@silverbullet233 silverbullet233 silverbullet233 approved these changes

Assignees

@trueeyu trueeyu

Labels
2.5 3.0 3.1 3.2 backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trueeyu @silverbullet233 @kangkaisen @wanpengfei-git