-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Optimize the inner-join performance of nest-loop-join when the right table is relatively small #35003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueeyu
changed the title
[WIP] Optimize the performance of nest-loop-join for inner join small table
[WIP] Optimize the inner-join performance of nest-loop-join when the right table is relatively small
Nov 14, 2023
Signed-off-by: trueeyu <[email protected]>
trueeyu
force-pushed
the
bitmap_opt_10
branch
from
November 17, 2023 07:14
c0b266d
to
5c9c950
Compare
trueeyu
changed the title
[WIP] Optimize the inner-join performance of nest-loop-join when the right table is relatively small
[Enhancement] Optimize the inner-join performance of nest-loop-join when the right table is relatively small
Nov 17, 2023
Signed-off-by: trueeyu <[email protected]>
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 0 / 62 (00.00%) file detail
|
satanson
approved these changes
Nov 20, 2023
fzhedu
reviewed
Nov 20, 2023
fzhedu
reviewed
Nov 20, 2023
fzhedu
approved these changes
Nov 20, 2023
https://github.com/Mergifyio backport branch-3.2 |
✅ Backports have been created
|
https://github.com/Mergifyio backport branch-3.1 |
✅ Backports have been created
|
https://github.com/Mergifyio backport branch-3.0 |
https://github.com/Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
…hen the right table is relatively small (#35003) Signed-off-by: trueeyu <[email protected]> (cherry picked from commit 62a52c1)
mergify bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
…hen the right table is relatively small (#35003) Signed-off-by: trueeyu <[email protected]> (cherry picked from commit 62a52c1)
mergify bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
…hen the right table is relatively small (#35003) Signed-off-by: trueeyu <[email protected]> (cherry picked from commit 62a52c1)
This was referenced Nov 20, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
…hen the right table is relatively small (#35003) Signed-off-by: trueeyu <[email protected]> (cherry picked from commit 62a52c1) # Conflicts: # be/src/exec/pipeline/nljoin/nljoin_probe_operator.cpp # be/src/exec/pipeline/nljoin/nljoin_probe_operator.h
trueeyu
added a commit
that referenced
this pull request
Nov 20, 2023
…hen the right table is relatively small (backport #35003) (#35384) Co-authored-by: trueeyu <[email protected]>
trueeyu
added a commit
to trueeyu/starrocks
that referenced
this pull request
Nov 20, 2023
…hen the right table is relatively small (StarRocks#35003) Signed-off-by: trueeyu <[email protected]>
trueeyu
added a commit
that referenced
this pull request
Nov 20, 2023
…hen the right table is relatively small (backport #35003) (#35382) Co-authored-by: trueeyu <[email protected]>
trueeyu
added a commit
that referenced
this pull request
Nov 20, 2023
…hen the right table is relatively small (backport #35003) (#35383) Co-authored-by: trueeyu <[email protected]>
trueeyu
added a commit
that referenced
this pull request
Nov 20, 2023
…hen the right table is relatively small (#35003) (#35400) Signed-off-by: trueeyu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
For nest-loop-join for inner join, if the right table is small such as one row,
In order to generate intermediate chunks, only a small number of rows will be appended at a time, which is very time-consuming.
What I'm doing:
For inner-join, we will generate the intermediate chunk base the larger chunk of build or probe.
Case 1:
Time: 11.974s -> 0.54s
Mem: 5.363M -> 4M
Case 2:
Time: 20.680s -> 9.428s
Mem: 30M -> 30M
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: