Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] sys.object_dependencies #35060

Merged
merged 11 commits into from
Nov 20, 2023
Merged

[Feature] sys.object_dependencies #35060

merged 11 commits into from
Nov 20, 2023

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Nov 15, 2023 •
edited
Loading

Why I'm doing:

What I'm doing:

  • Introduce a sys.object_dependencies view to show dependencies of objects

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@murphyatwork
introdce table
d580209 
Signed-off-by: Murphy <[email protected]>
@murphyatwork
introduce thrift
6090e86 
Signed-off-by: Murphy <[email protected]>
@murphyatwork
implement be
6d70070 
Signed-off-by: Murphy <[email protected]>
@murphyatwork
implement fe
956289b 
Signed-off-by: Murphy <[email protected]>
@murphyatwork
fix
37ba305 
Signed-off-by: Murphy <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 47 / 51 (92.16%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/system/sys/SysObjectDependencies.java 45 49 91.84% [39, 69, 81, 82]
🔵 com/starrocks/catalog/system/sys/SysDb.java 1 1 100.00% []
🔵 com/starrocks/service/FrontendServiceImpl.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 0 / 49 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exec/schema_scanner/schema_helper.cpp 0 2 00.00% [74, 77]
🔵 src/exec/schema_scanner.cpp 0 15 00.00% [170, 171, 240, 241, 242, 243, 245, 246, 248, 249, 251, 252, 254, 255, 258]
🔵 src/exec/schema_scanner/sys_object_dependencies.cpp 0 32 00.00% [40, 41, 43, 45, 46, 47, 49, 50, 51, 53, 56, 57, 58, 59, 60, 61, 63, 64, 65, 66, 67, 68, 70, 71, 74, 75, 76, 78, 79, 80, 82, 83]

@murphyatwork murphyatwork enabled auto-merge (squash) November 17, 2023 05:37
@murphyatwork murphyatwork merged commit 9756c20 into StarRocks:main Nov 20, 2023
47 of 49 checks passed
@murphyatwork
Copy link
Contributor Author

@Mergifyio backport branch-3.2 branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2023 •
edited
Loading

backport branch-3.2 branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 20, 2023
@murphyatwork @mergify
[Feature] sys.object_dependencies (#35060)
6717404 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 9756c20)
mergify bot pushed a commit that referenced this pull request Nov 20, 2023
@murphyatwork @mergify
[Feature] sys.object_dependencies (#35060)
04d66d7 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 9756c20)

# Conflicts:
#	be/src/exec/CMakeLists.txt
#	be/src/exec/schema_scanner.cpp
#	be/src/exec/schema_scanner/schema_helper.cpp
#	be/src/exec/schema_scanner/schema_helper.h
#	fe/fe-core/src/main/java/com/starrocks/catalog/system/SystemId.java
#	fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java
#	gensrc/thrift/Descriptors.thrift
This was referenced Nov 20, 2023
Merged
Merged
murphyatwork added a commit that referenced this pull request Nov 21, 2023
@murphyatwork
[Feature] sys.object_dependencies (#35060)
58ed770 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 9756c20)
wanpengfei-git pushed a commit that referenced this pull request Nov 21, 2023
@murphyatwork @wanpengfei-git
[Feature] sys.object_dependencies (#35060)
e17813c 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 9756c20)
murphyatwork added a commit that referenced this pull request Nov 27, 2023
@murphyatwork
Revert "[Feature] sys.object_dependencies (#35060)"
651178d 
This reverts commit e17813c.
murphyatwork added a commit that referenced this pull request Nov 27, 2023
@murphyatwork
Revert "[Feature] sys.object_dependencies (backport #35060)" (#35874)
8456e2e
@WholeWorld-Timothy
Copy link
Contributor

In the explanatory information, sys.object_dependecies are spelled incorrectly, it should be sys.object_dependencies.

@murphyatwork
Copy link
Contributor Author

@Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2023

backport branch-3.2

✅ Backports have been created

murphyatwork added a commit that referenced this pull request Nov 29, 2023
@murphyatwork
[Feature] sys.object_dependencies (#35060)
83ba328 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 9756c20)
murphyatwork added a commit that referenced this pull request Nov 29, 2023
@murphyatwork
Revert "Revert "[Feature] sys.object_dependencies (backport #35060)" (#…
9ae3b80 
…35874)"

This reverts commit 8456e2e.
murphyatwork added a commit that referenced this pull request Nov 29, 2023
@murphyatwork
Revert "Revert "[Feature] sys.object_dependencies (backport #35060)" (#…
ba7c5d4 
…35874)"

This reverts commit 8456e2e.
murphyatwork added a commit that referenced this pull request Nov 29, 2023
@murphyatwork
Revert "Revert "[Feature] sys.object_dependencies (backport #35060)"" (…
4b17669 
…#36057)
murphyatwork added a commit that referenced this pull request Dec 13, 2023
@murphyatwork
[Feature] sys.object_dependencies (#35060)
6ec6a38 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 9756c20)
Signed-off-by: Murphy <[email protected]>

# Conflicts:
#	be/src/exec/CMakeLists.txt
#	be/src/exec/schema_scanner.cpp
#	be/src/exec/schema_scanner/schema_helper.cpp
#	be/src/exec/schema_scanner/schema_helper.h
#	fe/fe-core/src/main/java/com/starrocks/catalog/system/SystemId.java
#	fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java
#	gensrc/thrift/Descriptors.thrift
murphyatwork added a commit that referenced this pull request Dec 14, 2023
@murphyatwork
[Feature] sys.object_dependencies (#35060)
4b1ade9 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 9756c20)
Signed-off-by: Murphy <[email protected]>
murphyatwork added a commit that referenced this pull request Dec 14, 2023
@murphyatwork
[Feature] sys.object_dependencies (#35060)
7d4baed 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 9756c20)
Signed-off-by: Murphy <[email protected]>
murphyatwork added a commit that referenced this pull request Dec 14, 2023
@murphyatwork
[Feature] sys.object_dependencies (#35060)
346fb19 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 9756c20)
Signed-off-by: Murphy <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Dec 15, 2023
@mergify @murphyatwork
[Feature] sys.object_dependencies (backport #35060) (#35424)
1760ab4 
Signed-off-by: Murphy <[email protected]>
Co-authored-by: Murphy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@packy92 packy92 packy92 approved these changes

@satanson satanson satanson approved these changes

Assignees

@murphyatwork murphyatwork

Labels
backport_ok behavior_changed PROTO-REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@murphyatwork @WholeWorld-Timothy @satanson @packy92 @wangruin