Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Delete files with retry in shared data mode #35566

Merged
merged 4 commits into from
Nov 23, 2023
Merged

[Enhancement] Delete files with retry in shared data mode #35566

merged 4 commits into from
Nov 23, 2023

Conversation

sduzh
Copy link
Contributor

@sduzh sduzh commented Nov 22, 2023

Why I'm doing:

Deletion fails after qps exceeds object store qps limit.

What I'm doing:

Add delete retry mechanism.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@mergify mergify bot assigned sduzh Nov 22, 2023
@sduzh
[UT] more tests
4aba6bf 
Signed-off-by: Alex Zhu <[email protected]>
@sduzh
Copy link
Contributor Author

sduzh commented Nov 22, 2023

Try to fix #35567

@sduzh sduzh changed the title [Enhancement] Delete files with retry [Enhancement] Delete files with retry in shared data mode Nov 22, 2023
@sduzh sduzh enabled auto-merge (squash) November 22, 2023 05:36
@sduzh sduzh requested review from kevincai and wyb November 22, 2023 05:36
wyb
wyb reviewed Nov 22, 2023
View reviewed changes
be/src/common/config.h Outdated Show resolved Hide resolved
be/src/storage/lake/vacuum.cpp Outdated Show resolved Hide resolved
@sduzh
[Refactor] Rename
79e5368 
Signed-off-by: Alex Zhu <[email protected]>
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 21 / 23 (91.30%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/service/staros_worker.cpp 0 2 00.00% [332, 333]
🔵 src/storage/lake/vacuum.cpp 20 20 100.00% []
🔵 src/fs/fs_posix.cpp 1 1 100.00% []

@sduzh sduzh merged commit 03df07a into StarRocks:main Nov 23, 2023
47 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 23, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 23, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 23, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 23, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 23, 2023
@sduzh @mergify
[Enhancement] Delete files with retry in shared data mode (#35566)
3979480 
Signed-off-by: Alex Zhu <[email protected]>
(cherry picked from commit 03df07a)
@mergify mergify bot mentioned this pull request Nov 23, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 23, 2023
@sduzh @mergify
[Enhancement] Delete files with retry in shared data mode (#35566)
0c10cff 
Signed-off-by: Alex Zhu <[email protected]>
(cherry picked from commit 03df07a)
@mergify mergify bot mentioned this pull request Nov 23, 2023
Merged
@sduzh sduzh deleted the enhancement/vacuum-with-retry branch November 23, 2023 03:10
github-actions bot pushed a commit that referenced this pull request Nov 23, 2023
@sduzh @github-actions
[Enhancement] Delete files with retry in shared data mode (#35566)
4049996 
Signed-off-by: Alex Zhu <[email protected]>
(cherry picked from commit 03df07a)
github-actions bot pushed a commit that referenced this pull request Nov 23, 2023
@sduzh @github-actions
[Enhancement] Delete files with retry in shared data mode (#35566)
f850d9a 
Signed-off-by: Alex Zhu <[email protected]>
(cherry picked from commit 03df07a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Astralidea Astralidea Astralidea approved these changes

@wyb wyb wyb approved these changes

@kevincai kevincai kevincai approved these changes

Assignees

@sduzh sduzh

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sduzh @kevincai @wyb @Astralidea @wanpengfei-git