Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] support mysql key words in where caluse #35917

Merged
merged 2 commits into from
Nov 29, 2023
Merged

[Enhancement] support mysql key words in where caluse #35917

merged 2 commits into from
Nov 29, 2023

Conversation

zombee0
Copy link
Contributor

@zombee0 zombee0 commented Nov 28, 2023 •
edited
Loading

Why I'm doing:

What I'm doing:
support mysql key words in where caluse

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@zombee0 zombee0 requested a review from a team as a code owner November 28, 2023 04:05
Youngwb
Youngwb previously approved these changes Nov 28, 2023
View reviewed changes
stephen-shelby
stephen-shelby previously approved these changes Nov 28, 2023
View reviewed changes
packy92
packy92 previously approved these changes Nov 28, 2023
View reviewed changes
@zombee0 zombee0 requested a review from a team as a code owner November 28, 2023 11:03
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 14 / 15 (93.33%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/analysis/SlotRef.java 0 1 00.00% [323]
🔵 com/starrocks/planner/JDBCScanNode.java 14 14 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 0 / 3 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/connector/jdbc_connector.cpp 0 3 00.00% [55, 57, 149]

@Youngwb Youngwb merged commit 7fdb26f into StarRocks:main Nov 29, 2023
57 of 58 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 29, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 29, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot removed the 3.0 label Nov 29, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Nov 29, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 29, 2023
@zombee0 @mergify
[Enhancement] support mysql key words in where caluse (#35917)
4de282c 
Signed-off-by: zombee0 <[email protected]>
(cherry picked from commit 7fdb26f)
mergify bot pushed a commit that referenced this pull request Nov 29, 2023
@zombee0 @mergify
[Enhancement] support mysql key words in where caluse (#35917)
1d76550 
Signed-off-by: zombee0 <[email protected]>
(cherry picked from commit 7fdb26f)
This was referenced Nov 29, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Nov 29, 2023
@zombee0 @mergify
[Enhancement] support mysql key words in where caluse (#35917)
587b144 
Signed-off-by: zombee0 <[email protected]>
(cherry picked from commit 7fdb26f)
@mergify mergify bot mentioned this pull request Nov 29, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 29, 2023
@zombee0 @mergify
[Enhancement] support mysql key words in where caluse (#35917)
7c5e3c6 
Signed-off-by: zombee0 <[email protected]>
(cherry picked from commit 7fdb26f)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/planner/JDBCScanNode.java
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/PlanTestBase.java
@mergify mergify bot mentioned this pull request Nov 29, 2023
Closed
wanpengfei-git pushed a commit that referenced this pull request Nov 29, 2023
@zombee0 @wanpengfei-git
[Enhancement] support mysql key words in where caluse (#35917)
e5667b8 
Signed-off-by: zombee0 <[email protected]>
(cherry picked from commit 7fdb26f)
wanpengfei-git pushed a commit that referenced this pull request Nov 29, 2023
@zombee0 @wanpengfei-git
[Enhancement] support mysql key words in where caluse (#35917)
0ad8724 
Signed-off-by: zombee0 <[email protected]>
(cherry picked from commit 7fdb26f)
wanpengfei-git pushed a commit that referenced this pull request Nov 29, 2023
@zombee0 @wanpengfei-git
[Enhancement] support mysql key words in where caluse (#35917)
d2e6ffb 
Signed-off-by: zombee0 <[email protected]>
(cherry picked from commit 7fdb26f)
@zombee0
Copy link
Contributor Author

zombee0 commented Dec 7, 2023

https://github.com/Mergifyio backport branch-2.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 7, 2023

backport branch-2.5

✅ Backports have been created

@zombee0 zombee0 mentioned this pull request Dec 7, 2023
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay left review comments

@packy92 packy92 packy92 approved these changes

@Youngwb Youngwb Youngwb approved these changes

@stephen-shelby stephen-shelby stephen-shelby left review comments

Assignees

@zombee0 zombee0

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zombee0 @imay @Youngwb @stephen-shelby @packy92 @wangruin