[Enhancement] Add a runtime config to enable log stream load request/response #36113

meegoo · 2023-11-30T00:26:01Z

Why I'm doing:

many user may not log stream load http request/response, so we need to log it online when we debug or tuning.

What I'm doing:

add enable_stream_load_verbose_log to control it

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

be/src/http/action/transaction_stream_load.cpp

wyb · 2023-11-30T05:13:36Z

better to support runtime modification of sys_log_verbose_modules and sys_log_verbose_level configs?

be/src/http/action/stream_load.cpp

be/src/http/action/transaction_stream_load.cpp

meegoo · 2023-12-01T00:29:21Z

better to support runtime modification of sys_log_verbose_modules and sys_log_verbose_level configs?

sys_log_verbose_modules only can control namespace level

be/src/http/action/stream_load.cpp

…response Signed-off-by: meegoo <[email protected]>

github-actions · 2023-12-06T03:46:25Z

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2023-12-06T03:48:04Z

[BE Incremental Coverage Report]

❌ fail : 9 / 14 (64.29%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	src/http/action/transaction_stream_load.cpp	2	4	50.00%	[93, 189]
🔵	src/http/action/stream_load.cpp	7	10	70.00%	[141, 237, 245]

github-actions · 2023-12-06T04:02:13Z

@Mergifyio backport branch-3.2

github-actions · 2023-12-06T04:02:14Z

@Mergifyio backport branch-3.1

github-actions · 2023-12-06T04:02:16Z

@Mergifyio backport branch-3.0

github-actions · 2023-12-06T04:02:18Z

@Mergifyio backport branch-2.5

mergify · 2023-12-06T04:02:33Z

backport branch-3.2

✅ Backports have been created

#36504 [Enhancement] Add a runtime config to enable log stream load request/response (backport #36113) has been created for branch branch-3.2

mergify · 2023-12-06T04:02:34Z

backport branch-3.1

✅ Backports have been created

#36505 [Enhancement] Add a runtime config to enable log stream load request/response (backport #36113) has been created for branch branch-3.1

mergify · 2023-12-06T04:02:36Z

backport branch-3.0

✅ Backports have been created

#36506 [Enhancement] Add a runtime config to enable log stream load request/response (backport #36113) has been created for branch branch-3.0

mergify · 2023-12-06T04:02:38Z

backport branch-2.5

✅ Backports have been created

#36507 [Enhancement] Add a runtime config to enable log stream load request/response (backport #36113) has been created for branch branch-2.5

…response (#36113) Signed-off-by: meegoo <[email protected]> (cherry picked from commit c5863c0)

…response (backport #36113) (#36507) Co-authored-by: meegoo <[email protected]>

…response (backport #36113) (#36506) Co-authored-by: meegoo <[email protected]>

…response (backport #36113) (#36505) Co-authored-by: meegoo <[email protected]>

…response (backport #36113) (#36504) Co-authored-by: meegoo <[email protected]>

…response (StarRocks#36113) Signed-off-by: meegoo <[email protected]> Signed-off-by: 鼎昕 <[email protected]>

starrocks-cr bot reviewed Nov 30, 2023

View reviewed changes

be/src/http/action/transaction_stream_load.cpp Outdated Show resolved Hide resolved

mergify bot assigned meegoo Nov 30, 2023

github-actions bot added 3.2 3.1 3.0 2.5 labels Nov 30, 2023

meegoo enabled auto-merge (squash) November 30, 2023 03:08

chaoyli previously approved these changes Nov 30, 2023

View reviewed changes

banmoy reviewed Nov 30, 2023

View reviewed changes

be/src/http/action/stream_load.cpp Outdated Show resolved Hide resolved

banmoy reviewed Nov 30, 2023

View reviewed changes

be/src/http/action/transaction_stream_load.cpp Outdated Show resolved Hide resolved

meegoo dismissed chaoyli’s stale review via 9a850b6 December 4, 2023 19:33

meegoo force-pushed the runtime_log_stream_load branch 2 times, most recently from 9a850b6 to fd5473a Compare December 4, 2023 19:52

banmoy reviewed Dec 5, 2023

View reviewed changes

be/src/http/action/stream_load.cpp Outdated Show resolved Hide resolved

meegoo disabled auto-merge December 5, 2023 07:36

banmoy approved these changes Dec 5, 2023

View reviewed changes

meegoo force-pushed the runtime_log_stream_load branch from d53fc9c to c8b2386 Compare December 5, 2023 19:37

meegoo enabled auto-merge (squash) December 5, 2023 19:41

[Enhancement] Add a runtime config to enable log stream load request/…

f4566af

…response Signed-off-by: meegoo <[email protected]>

meegoo force-pushed the runtime_log_stream_load branch from c8b2386 to f4566af Compare December 6, 2023 02:11

wyb approved these changes Dec 6, 2023

View reviewed changes

chaoyli approved these changes Dec 6, 2023

View reviewed changes

meegoo merged commit c5863c0 into StarRocks:main Dec 6, 2023
40 of 41 checks passed

github-actions bot removed 3.2 3.1 labels Dec 6, 2023

github-actions bot removed the 3.0 label Dec 6, 2023

github-actions bot removed the 2.5 label Dec 6, 2023

mergify bot pushed a commit that referenced this pull request Dec 6, 2023

[Enhancement] Add a runtime config to enable log stream load request/…

10ad7e7

…response (#36113) Signed-off-by: meegoo <[email protected]> (cherry picked from commit c5863c0)

mergify bot mentioned this pull request Dec 6, 2023

[Enhancement] Add a runtime config to enable log stream load request/response (backport #36113) #36504

Merged

mergify bot pushed a commit that referenced this pull request Dec 6, 2023

[Enhancement] Add a runtime config to enable log stream load request/…

b45a8b4

…response (#36113) Signed-off-by: meegoo <[email protected]> (cherry picked from commit c5863c0)

mergify bot mentioned this pull request Dec 6, 2023

[Enhancement] Add a runtime config to enable log stream load request/response (backport #36113) #36505

Merged

mergify bot pushed a commit that referenced this pull request Dec 6, 2023

[Enhancement] Add a runtime config to enable log stream load request/…

3809acb

…response (#36113) Signed-off-by: meegoo <[email protected]> (cherry picked from commit c5863c0)

mergify bot mentioned this pull request Dec 6, 2023

[Enhancement] Add a runtime config to enable log stream load request/response (backport #36113) #36506

Merged

mergify bot pushed a commit that referenced this pull request Dec 6, 2023

[Enhancement] Add a runtime config to enable log stream load request/…

2966d87

…response (#36113) Signed-off-by: meegoo <[email protected]> (cherry picked from commit c5863c0)

mergify bot mentioned this pull request Dec 6, 2023

[Enhancement] Add a runtime config to enable log stream load request/response (backport #36113) #36507

Merged

meegoo added a commit that referenced this pull request Dec 8, 2023

[Enhancement] Add a runtime config to enable log stream load request/…

f3342c8

…response (backport #36113) (#36507) Co-authored-by: meegoo <[email protected]>

meegoo added a commit that referenced this pull request Dec 8, 2023

[Enhancement] Add a runtime config to enable log stream load request/…

eb9bb32

…response (backport #36113) (#36506) Co-authored-by: meegoo <[email protected]>

meegoo added a commit that referenced this pull request Dec 8, 2023

[Enhancement] Add a runtime config to enable log stream load request/…

35c8f83

…response (backport #36113) (#36505) Co-authored-by: meegoo <[email protected]>

meegoo added a commit that referenced this pull request Dec 8, 2023

[Enhancement] Add a runtime config to enable log stream load request/…

b34729d

…response (backport #36113) (#36504) Co-authored-by: meegoo <[email protected]>

wanpengfei-git added the backport_ok label Dec 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement] Add a runtime config to enable log stream load request/response #36113

[Enhancement] Add a runtime config to enable log stream load request/response #36113

meegoo commented Nov 30, 2023 •

edited

Loading

wyb commented Nov 30, 2023

meegoo commented Dec 1, 2023

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

mergify bot commented Dec 6, 2023 •

edited

Loading

mergify bot commented Dec 6, 2023 •

edited

Loading

mergify bot commented Dec 6, 2023 •

edited

Loading

mergify bot commented Dec 6, 2023 •

edited

Loading

[Enhancement] Add a runtime config to enable log stream load request/response #36113

[Enhancement] Add a runtime config to enable log stream load request/response #36113

Conversation

meegoo commented Nov 30, 2023 • edited Loading

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

wyb commented Nov 30, 2023

meegoo commented Dec 1, 2023

github-actions bot commented Dec 6, 2023

[FE Incremental Coverage Report]

github-actions bot commented Dec 6, 2023

[BE Incremental Coverage Report]

file detail

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

mergify bot commented Dec 6, 2023 • edited Loading

✅ Backports have been created

mergify bot commented Dec 6, 2023 • edited Loading

✅ Backports have been created

mergify bot commented Dec 6, 2023 • edited Loading

✅ Backports have been created

mergify bot commented Dec 6, 2023 • edited Loading

✅ Backports have been created

meegoo commented Nov 30, 2023 •

edited

Loading

mergify bot commented Dec 6, 2023 •

edited

Loading

mergify bot commented Dec 6, 2023 •

edited

Loading

mergify bot commented Dec 6, 2023 •

edited

Loading

mergify bot commented Dec 6, 2023 •

edited

Loading