-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Pushdown distinct agg across window not support complex expr #36357
Conversation
fe/fe-core/src/main/java/com/starrocks/sql/optimizer/LogicalPlanPrinter.java
Show resolved
Hide resolved
f469c95
to
65251f6
Compare
65251f6
to
f5ec162
Compare
Signed-off-by: satanson <[email protected]>
f5ec162
to
47d81ae
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs 0.0% Coverage The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 4 / 17 (23.53%) file detail
|
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-3.0 |
✅ Backports have been created
|
✅ Backports have been created
|
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
…#36357) Signed-off-by: satanson <[email protected]> (cherry picked from commit 7a0c140) # Conflicts: # fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
…#36357) Signed-off-by: satanson <[email protected]> (cherry picked from commit 7a0c140) # Conflicts: # fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
…#36357) Signed-off-by: satanson <[email protected]> (cherry picked from commit 7a0c140) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/LogicalPlanPrinter.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/pdagg/PushDownDistinctAggregateRewriter.java # fe/fe-core/src/test/java/com/starrocks/sql/plan/AggregatePushDownTest.java # fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
…#36357) Signed-off-by: satanson <[email protected]> (cherry picked from commit 7a0c140) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/LogicalPlanPrinter.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/pdagg/PushDownDistinctAggregateRewriter.java # fe/fe-core/src/test/java/com/starrocks/sql/plan/AggregatePushDownTest.java # fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
…(backport StarRocks#36357) Signed-off-by: satanson <[email protected]>
…(backport StarRocks#36357) Signed-off-by: satanson <[email protected]>
…(backport StarRocks#36357) Signed-off-by: satanson <[email protected]>
…(backport StarRocks#36357) Signed-off-by: satanson <[email protected]>
…(backport StarRocks#36357) Signed-off-by: satanson <[email protected]>
…(backport #36357) (#36498) Signed-off-by: satanson <[email protected]>
…(backport #36357) (#36499) Signed-off-by: satanson <[email protected]>
…StarRocks#36357) Signed-off-by: satanson <[email protected]> Signed-off-by: 鼎昕 <[email protected]>
Why I'm doing:
Pushdown DistinctAgg across window operator does not support complex expr that uses output column of the window operator, it report error when encounters with it, the query report an error as follows:
The error message as follows:
What I'm doing:
Support the scenarios that disitinct columns are complex exprs that use output columns of window operator.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: