Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Pushdown distinct agg across window not support complex expr #36357

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

satanson
Copy link
Contributor

@satanson satanson commented Dec 4, 2023

Why I'm doing:

Pushdown DistinctAgg across window operator does not support complex expr that uses output column of the window operator, it report error when encounters with it, the query report an error as follows:

with temp as ( 
select TIME, ceil(round(sum(`NUM`) OVER (PARTITION BY `TIME` ))) from test_data
) select distinct * from temp;

The error message as follows:

java.lang.IllegalArgumentException: null
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:129) ~[spark-dpp-1.0.0.jar:?]
	at com.starrocks.sql.optimizer.rule.tree.pdagg.PushDownDistinctAggregateRewriter$PostVisitor.visitLogicalTableScan(PushDownDistinctAggregateRewriter.java:351) ~[starrocks-fe.jar:?]
	at com.starrocks.sql.optimizer.rule.tree.pdagg.PushDownDistinctAggregateRewriter$PostVisitor.visitLogicalTableScan(PushDownDistinctAggregateRewriter.java:311) ~[starrocks-fe.jar:?]
	at com.starrocks.sql.optimizer.operator.logical.LogicalScanOperator.accept(LogicalScanOperator.java:187) ~[starrocks-fe.jar:?]
	at com.starrocks.sql.optimizer.rule.tree.pdagg.PushDownDistinctAggregateRewriter.processPost(PushDownDistinctAggregateRewriter.java:475) ~[starrocks-fe.jar:?]
	at com.starrocks.sql.optimizer.rule.tree.pdagg.PushDownDistinctAggregateRewriter.lambda$process$3(PushDownDistinctAggregateRewriter.java:484) ~[starrocks-fe.jar:?]
	at java.util.Optional.map(Optional.java:215) ~[?:1.8.0_181]
	at com.starrocks.sql.optimizer.rule.tree.pdagg.PushDownDistinctAggregateRewriter.process(PushDownDistinctAggregateRewriter.java:484) ~[starrocks-fe.jar:?]
	at com.starrocks.sql.optimizer.rule.tree.pdagg.PushDownDistinctAggregateRewriter.lambda$processChildren$0(PushDownDistinctAggregateRewriter.java:445) ~[starrocks-fe.jar:?]
	at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) ~[?:1.8.0_181]
	at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1382) ~[?:1.8.0_181]
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481) ~[?:1.8.0_181]
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471) ~[?:1.8.0_181]

What I'm doing:

Support the scenarios that disitinct columns are complex exprs that use output columns of window operator.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@satanson satanson changed the title [BugFix] Pushdown distinct agg across window [BugFix] Pushdown distinct agg across window not support complex expr Dec 4, 2023
Seaven
Seaven previously approved these changes Dec 4, 2023
packy92
packy92 previously approved these changes Dec 4, 2023
@satanson satanson dismissed stale reviews from packy92 and Seaven via 47d81ae December 4, 2023 13:07
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

github-actions bot commented Dec 4, 2023

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Dec 4, 2023

[FE Incremental Coverage Report]

fail : 4 / 17 (23.53%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/LogicalPlanPrinter.java 0 13 00.00% [257, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 272]
🔵 com/starrocks/sql/optimizer/rule/tree/pdagg/PushDownDistinctAggregateRewriter.java 4 4 100.00% []

@kangkaisen kangkaisen merged commit 7a0c140 into StarRocks:main Dec 5, 2023
45 of 46 checks passed
Copy link

github-actions bot commented Dec 5, 2023

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

@Mergifyio backport branch-3.0

Copy link
Contributor

mergify bot commented Dec 5, 2023

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Dec 5, 2023

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 3.0 label Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Dec 5, 2023
Copy link
Contributor

mergify bot commented Dec 5, 2023

backport branch-3.0

✅ Backports have been created

Copy link
Contributor

mergify bot commented Dec 5, 2023

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 5, 2023
…#36357)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 7a0c140)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
mergify bot pushed a commit that referenced this pull request Dec 5, 2023
…#36357)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 7a0c140)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
mergify bot pushed a commit that referenced this pull request Dec 5, 2023
…#36357)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 7a0c140)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/LogicalPlanPrinter.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/pdagg/PushDownDistinctAggregateRewriter.java
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/AggregatePushDownTest.java
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
mergify bot pushed a commit that referenced this pull request Dec 5, 2023
…#36357)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 7a0c140)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/LogicalPlanPrinter.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/pdagg/PushDownDistinctAggregateRewriter.java
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/AggregatePushDownTest.java
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
satanson added a commit to satanson/starrocks that referenced this pull request Dec 6, 2023
satanson added a commit to satanson/starrocks that referenced this pull request Dec 6, 2023
satanson added a commit to satanson/starrocks that referenced this pull request Dec 6, 2023
satanson added a commit to satanson/starrocks that referenced this pull request Dec 6, 2023
satanson added a commit to satanson/starrocks that referenced this pull request Dec 6, 2023
kangkaisen pushed a commit that referenced this pull request Dec 6, 2023
kangkaisen pushed a commit that referenced this pull request Dec 6, 2023
dingxin-tech pushed a commit to dingxin-tech/starrocks-odps that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants